Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor espflash command update #80

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

Ricardicus
Copy link
Contributor

Minor update to the espflash save-image command,

I got this error:

$ cargo espflash save-image --merge ESP32 outfile.bin --release
error: Found argument 'outfile.bin' which wasn't expected, or isn't valid in this context

Usage: cargo espflash save-image [OPTIONS] --chip <CHIP> <FILE>

For more information try '--help'

They might have changed so that --chip is needed and ESP in capital letters wasn't working for me.

@SergioGasquez
Copy link
Member

Which version of cargo-espflash are you using?

@Ricardicus
Copy link
Contributor Author

I am using cargo-espflash-espflash 2.0.0-rc.3 , seems to be the latest and greatest:
https://github.com/esp-rs/espflash/releases

@SergioGasquez
Copy link
Member

The book commands are using espflash and cargo-espflash 1 since 2.0 hasn't been officially released (still a release candidate). Once 2.0 is released, we will update all the espflash commands in the book, see #50.

@Ricardicus
Copy link
Contributor Author

Ricardicus commented Apr 14, 2023

Ok! I got espflash from following the guide. I just did cargo install espflash. Strange that I got a release candidate directly from cargo.. anyways! Maybe this can be included in that update

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks for the contribution. Now that espflash 2.0.0 has been released, we can merge it!

@SergioGasquez SergioGasquez merged commit 7e24acb into esp-rs:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants