Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed fqrate from uint to uint64 to allow pacing above 32G #1728

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

marcosfsch
Copy link
Contributor

@swlars swlars self-assigned this Jul 26, 2024
@swlars
Copy link
Contributor

swlars commented Jul 29, 2024

Hi, we like this change, but we're concerned about compatibility on supported devices with a Linux kernel version that's less than 5, like Rocky8. Do you know of a way to detect at run or compile time if 64-bit values are accepted?

@marcosfsch
Copy link
Contributor Author

I don't know a way to test the values at runtime, but I just compiled and runned iperf3 with this patch and it silently trims the value to 32-bits on rocky8, and mantains the behaviour without tha patch. i.e. if you set above 32G it overloads and start from zero again.

@swlars
Copy link
Contributor

swlars commented Aug 5, 2024

We also tested it and it seems to work as expected. We have not tested on any big-endian systems, so we'll probably make a note of that somewhere. Thanks for the merge request!

@swlars swlars merged commit f89aee0 into esnet:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants