Prevent UDP packet count and operations overflow #1536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
master
or3.1-STABLE
) to which this pull request applies:master
Issues fixed (if any):
UDP loss data not calculated correctly? #1534
Brief description of code changes (suitable for use as a commit message):
Make all variables related to UDP packets numbers and related calculations
int64_t
. Although--udp-counters-64bit
options allows UDP packet number to be larger than 2^32 bits, several of these related variables were defined asint
which is 32 nits in several environments. Note thatint64_t
is used and notuint64_t
to keep sign compatibility with the replacedint
(assuming that the 63 bits limit is large enough).In addition,
report_bw_udp/report_sum_bw_udp...
definitions iniperf_locale.c
were changed to use%PRIu64
instead of%d
when printing packets counts. Note that the relatedreportCSV_bw_udp_format
was not changed, as I am not sure how it is used.