Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding folder permissions support. #173

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Adding folder permissions support. #173

merged 3 commits into from
Jul 13, 2023

Conversation

safaci2000
Copy link
Contributor

ChangeLog:

@safaci2000 safaci2000 requested a review from arlake228 July 3, 2023 16:26
@safaci2000 safaci2000 force-pushed the feature/folders branch 4 times, most recently from eb070d3 to 3b635c0 Compare July 7, 2023 13:06
@safaci2000 safaci2000 requested a review from daldoyle July 12, 2023 19:39
@safaci2000
Adding folder permissions support.
87fbfe8 
ChangeLog:
  - Adding support for import/export/list folder permissions. #167
  - BUG: Fixing a bug with invalid SSL for custom REST API calls.
  - BUG: Fixing Special character behavior with Dashboard Folder
    import/export. #170
  - Fixing behavior for cloud based configuraiton
@safaci2000 safaci2000 force-pushed the feature/folders branch 3 times, most recently from 9ceaa9d to 003dd93 Compare July 12, 2023 22:49
daldoyle
daldoyle reviewed Jul 13, 2023
View reviewed changes
internal/service/folders.go Outdated Show resolved Hide resolved
internal/service/folders.go Outdated
result = append(result, folderListing.GetPayload()[ndx])
} else if filter.ValidateAll(map[filters.FilterType]string{filters.FolderFilter: val.Title}) {
if !valid {
log.Warningf("Folder '%s' has an invalid character and is not supported", val.Title)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above re: what characters are invalid.

internal/service/folders.go Show resolved Hide resolved
cmd/folderPermissions.go Outdated Show resolved Hide resolved
cmd/folderPermissions.go Outdated Show resolved Hide resolved
@safaci2000 safaci2000 merged commit f27f92f into master Jul 13, 2023
3 checks passed
@safaci2000 safaci2000 deleted the feature/folders branch July 13, 2023 17:30
This was referenced Jul 13, 2023
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daldoyle daldoyle daldoyle approved these changes

@arlake228 arlake228 Awaiting requested review from arlake228

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safaci2000 @daldoyle