fix: update matchPackageNames to exclude 'github' actions#43
fix: update matchPackageNames to exclude 'github' actions#43lumirlumir merged 2 commits intomainfrom
Conversation
|
should we also exclude "googleapis/*" - i think it's well-trusted too. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Renovate configuration to exclude both actions/** and github/** packages from having their GitHub Actions pinned to commit digests. This ensures that first-party GitHub Actions (from both the actions and github namespaces) remain unpinned, while third-party actions continue to be pinned for security purposes.
Key Changes
- Expanded the exclusion pattern in the "Pin 3rd-party actions" rule to include both
actions/**andgithub/**namespaces
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Personally, I'm also +1 on excluding it. They're Google-owned actions, so I think that's fine. But, if the TSC has a moment to review it, another confirmation would be helpful. @eslint/eslint-tsc |
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Since eslint/js#712 (comment) and the related PRs for the release-please version pinning have been merged, I'm merging this now to align with them.
should we also exclude "googleapis/*" - i think it's well-trusted too.
If it really matters, I think we can start to discuss it in a separate issue :)
refs: eslint/eslint#20397 (comment)
This pull request makes a small update to the Renovate configuration for GitHub Actions dependencies. The change expands the exclusion pattern in the
matchPackageNamesfield to also excludegithub/**packages, not justactions/**..github/renovate/base.json5: Updated thematchPackageNamespattern to exclude bothactions/**andgithub/**when applying thedeps:actionslabel for GitHub Actions dependencies.Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?