Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Convert range and line number corretly in JSX literals #277

Merged
merged 1 commit into from
May 21, 2017

Conversation

soda0289
Copy link
Member

I ony fixed the JSXText tokens in my last commit. The Literal node needs to be fixed to use the correct range and line number. This fixes more issue with eslint-plugin-react rules

@soda0289 soda0289 requested a review from JamesHenry May 20, 2017 17:10
@eslintbot
Copy link

Thanks for the pull request, @soda0289! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@JamesHenry JamesHenry merged commit b4eb0b5 into master May 21, 2017
@JamesHenry JamesHenry deleted the fix-jsx-literal-loc branch May 21, 2017 10:53
@OliverJAsh
Copy link

Any ideas when will this be released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants