This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Convert MetaProperty (new.target) nodes correcly (fixes #194)#195
Merged
JamesHenry merged 1 commit intoeslint:masterfrom Mar 18, 2017
Merged
Fix: Convert MetaProperty (new.target) nodes correcly (fixes #194)#195JamesHenry merged 1 commit intoeslint:masterfrom
JamesHenry merged 1 commit intoeslint:masterfrom
Conversation
|
LGTM |
soda0289
commented
Mar 18, 2017
tests/lib/basics.js
Outdated
| result = tester.getRaw(result); | ||
| if (Object.keys(expected).length === 0) { | ||
| console.log(JSON.stringify(result, null, 4)); | ||
| } |
Member
Author
There was a problem hiding this comment.
I got to delete this. Sorry
Member
There was a problem hiding this comment.
Just in time 😄 I was just reviewing
soda0289
force-pushed
the
fix-metaproperty
branch
from
d507738 to
0633e73
Compare
|
LGTM |
JamesHenry
suggested changes
Mar 18, 2017
Member
JamesHenry
left a comment
JamesHenry
left a comment
There was a problem hiding this comment.
@soda0289 Please could we add the test case from espree for new.target as part of this?
Member
Author
|
We have those tests already: I had to enable the new-target rule by removing it from the filter in tests/lib/ecma-features.js Typescript does not throw an error you have an invalid metaproperty, such as |
Member
|
Ah! Sorry, that makes sense |
JamesHenry
approved these changes
Mar 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MetaProperty node was added a couple of months ago into typescript. I think it landed in 2.2.
microsoft/TypeScript#12783
I have to create a identifier node for 'new' since it is not part of the typescript metaproperty node.