Skip to content

chore: flatten dist directory and follow ESLint conventions#602

Merged
DMartens merged 5 commits intomainfrom
chore/flatten-dist-directory-and-follow-eslint-common-convention
Jan 19, 2026
Merged

chore: flatten dist directory and follow ESLint conventions#602
DMartens merged 5 commits intomainfrom
chore/flatten-dist-directory-and-follow-eslint-common-convention

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Jan 2, 2026

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've flattened the build output by moving files from dist/esm into dist and followed the ESLint convention of using defineConfig.

The primary reason for moving the build output to dist is to align with conventions used by other plugins such as CSS and JSON. In eslint/json#197 and eslint/css#352, I moved their build outputs from dist/esm to dist, since there's no longer a reason to support dual CommonJS/ESM packages going forward.

Also, I applied the previously missing defineConfig helper across the repository.

What changes did you make? (Give an overview)

In this PR, I've flattened the build output by moving files from dist/esm into dist and followed the ESLint convention of using defineConfig.

Related Issues

Ref: eslint/json#197, eslint/css#352

Is there anything you'd like reviewers to focus on?

N/A

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 2, 2026
@eslintbot eslintbot added this to Triage Jan 2, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jan 2, 2026
@github-actions

This comment was marked as resolved.

…flatten-dist-directory-and-follow-eslint-common-convention
import markdown from "../../src/index.js";
import tseslint from "typescript-eslint";

export default tseslint.config(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tseslint.config() is now deprecated:

Image

@lumirlumir lumirlumir marked this pull request as ready for review January 13, 2026 13:55
Copilot AI review requested due to automatic review settings January 13, 2026 13:55
@lumirlumir lumirlumir requested a review from a team January 13, 2026 13:56
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage Jan 13, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR flattens the build output directory from dist/esm to dist to align with conventions used in other ESLint plugins (JSON and CSS), and applies the ESLint defineConfig helper across example configuration files.

Changes:

  • Updated build output directory from dist/esm to dist in TypeScript configuration and package entry points
  • Applied defineConfig helper to example configuration files
  • Modernized ESLint config patterns using globalIgnores helper

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.json Updated outDir from dist/esm to dist
package.json Updated main, types, and exports paths to reference dist instead of dist/esm; reordered build script for consistency
jsr.json Updated exports path from dist/esm to dist
examples/typescript/eslint.config.mjs Applied defineConfig helper and attempted to simplify config array structure
examples/react/eslint.config.mjs Applied defineConfig helper and attempted to simplify config array structure
eslint.config-content.js Applied defineConfig and globalIgnores helpers
.github/workflows/ci.yml Renamed job from are-the-types-wrong to are_the_types_wrong for naming consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lumirlumir lumirlumir marked this pull request as draft January 16, 2026 13:51
…flatten-dist-directory-and-follow-eslint-common-convention
@lumirlumir lumirlumir marked this pull request as ready for review January 19, 2026 14:36
@DMartens
Copy link
Contributor

Changes make sense and LGTM, thanks.

@DMartens DMartens merged commit 0d68897 into main Jan 19, 2026
25 checks passed
@DMartens DMartens deleted the chore/flatten-dist-directory-and-follow-eslint-common-convention branch January 19, 2026 19:16
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants