Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…flatten-dist-directory-and-follow-eslint-common-convention
lumirlumir
commented
Jan 13, 2026
| import markdown from "../../src/index.js"; | ||
| import tseslint from "typescript-eslint"; | ||
|
|
||
| export default tseslint.config( |
Member
Author
There was a problem hiding this comment.
Pull request overview
This PR flattens the build output directory from dist/esm to dist to align with conventions used in other ESLint plugins (JSON and CSS), and applies the ESLint defineConfig helper across example configuration files.
Changes:
- Updated build output directory from
dist/esmtodistin TypeScript configuration and package entry points - Applied
defineConfighelper to example configuration files - Modernized ESLint config patterns using
globalIgnoreshelper
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Updated outDir from dist/esm to dist |
| package.json | Updated main, types, and exports paths to reference dist instead of dist/esm; reordered build script for consistency |
| jsr.json | Updated exports path from dist/esm to dist |
| examples/typescript/eslint.config.mjs | Applied defineConfig helper and attempted to simplify config array structure |
| examples/react/eslint.config.mjs | Applied defineConfig helper and attempted to simplify config array structure |
| eslint.config-content.js | Applied defineConfig and globalIgnores helpers |
| .github/workflows/ci.yml | Renamed job from are-the-types-wrong to are_the_types_wrong for naming consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…flatten-dist-directory-and-follow-eslint-common-convention
Contributor
|
Changes make sense and LGTM, thanks. |
DMartens
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've flattened the build output by moving files from
dist/esmintodistand followed the ESLint convention of usingdefineConfig.The primary reason for moving the build output to
distis to align with conventions used by other plugins such as CSS and JSON. In eslint/json#197 and eslint/css#352, I moved their build outputs fromdist/esmtodist, since there's no longer a reason to support dual CommonJS/ESM packages going forward.Also, I applied the previously missing
defineConfighelper across the repository.What changes did you make? (Give an overview)
In this PR, I've flattened the build output by moving files from
dist/esmintodistand followed the ESLint convention of usingdefineConfig.Related Issues
Ref: eslint/json#197, eslint/css#352
Is there anything you'd like reviewers to focus on?
N/A