Skip to content

ci: run arethetypeswrong in CI #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzakas merged 1 commit into from
Dec 10, 2025
Merged

ci: run arethetypeswrong in CI #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ jobs:
run: npm install eslint@${{ matrix.eslint }}
- name: Test
run: npm run test

test_types:
name: Test Types
runs-on: ubuntu-latest
Expand All @@ -84,10 +85,23 @@ jobs:
node-version: "lts/*"
- name: Install dependencies
run: npm install
- name: Build
run: npm run build
- name: Check Types
run: npm run test:types

are-the-types-wrong:
name: Are the types wrong?
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: "lts/*"
- name: Install Packages
run: npm install
- name: Check validity of type definitions
run: npm run lint:types

jsr_test:
name: Verify JSR Publish
runs-on: ubuntu-latest
Expand All @@ -99,6 +113,4 @@ jobs:
- name: Install Packages
run: npm install
- name: Run --dry-run
run: |
npm run build
npm run test:jsr
run: npm run test:jsr
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"scripts": {
"lint": "eslint && eslint -c eslint.config-content.js",
"lint:fix": "eslint --fix && eslint --fix -c eslint.config-content.js",
"lint:types": "attw --pack --profile esm-only",
Copy link
Member Author

@lumirlumir lumirlumir Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the @eslint/markdown package is ESM-only, so I added the --profile esm-only option.

"lint:unused": "knip",
"fmt": "prettier --write .",
"fmt:check": "prettier --check .",
Expand All @@ -74,6 +75,7 @@
"test:types": "tsc -p tests/types/tsconfig.json"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.18.2",
"@eslint/js": "^9.39.1",
"@eslint/json": "^0.14.0",
"@types/mdast": "^4.0.4",
Expand Down