Skip to content

fix!: remove rollup and extraneous types #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025
Merged

fix!: remove rollup and extraneous types #383

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36c9f84
chore: remove rollup
xbinaryx May 20, 2025
50fe914
fix test
xbinaryx May 21, 2025
624f5fe
update jsr.json
xbinaryx May 22, 2025
57c069e
Merge branch 'main' into remove-rollup
xbinaryx Jun 18, 2025
3bda8b8
Merge branch 'main' into remove-rollup
xbinaryx Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions jsr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@
"exports": "./dist/esm/index.js",
"publish": {
"include": [
"dist/esm/index.js",
"dist/esm/index.d.ts",
"dist/esm/types.ts",
"dist/esm/types.d.ts",
"dist",
"README.md",
"jsr.json",
"LICENSE"
Expand Down
6 changes: 1 addition & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@
"lint:fix": "eslint --fix . && eslint --fix -c eslint.config-content.js .",
"fmt": "prettier --write .",
"fmt:check": "prettier --check .",
"build:dedupe-types": "node tools/dedupe-types.js dist/esm/index.js",
"build:rules": "node tools/build-rules.js",
"build:update-rules-docs": "node tools/update-rules-docs.js",
"build": "npm run build:rules && rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:update-rules-docs",
"build": "npm run build:rules && tsc && npm run build:update-rules-docs",
"build:readme": "node tools/update-readme.js",
"prepare": "node ./npm-prepare.cjs && npm run build",
"test": "c8 mocha \"tests/**/*.test.js\" --timeout 30000",
Expand All @@ -81,9 +80,6 @@
"lint-staged": "^15.2.9",
"mocha": "^10.6.0",
"prettier": "^3.3.3",
"rollup": "^4.19.0",
"rollup-plugin-copy": "^3.5.0",
"rollup-plugin-delete": "^3.0.1",
"typescript": "^5.5.4",
"yorkie": "^2.0.0"
},
Expand Down
19 changes: 0 additions & 19 deletions rollup.config.js
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions tests/types/types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import markdown, {
MarkdownSourceCode,
MarkdownNode,
MarkdownRuleDefinition,
MarkdownRuleVisitor,
SourceLocation,
SourceRange,
type RuleModule,
} from "@eslint/markdown";
import type { SourceLocation, SourceRange } from "@eslint/core";
import { Toml } from "@eslint/markdown/types";
import { ESLint, Linter } from "eslint";
import type {
Expand Down Expand Up @@ -167,8 +165,8 @@ typeof processorPlugins satisfies {};
"toml:exit": (...args) => testVisitor<Toml>(...args),

// Unknown selectors allowed
"heading[depth=1]"(node: MarkdownNode, parent?: ParentNode) {},
"randomSelector:exit"(node: MarkdownNode, parent?: ParentNode) {},
"heading[depth=1]"(node: Node, parent?: ParentNode) {},
"randomSelector:exit"(node: Node, parent?: ParentNode) {},
};
},
});
Expand Down
48 changes: 0 additions & 48 deletions tools/dedupe-types.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tsconfig.esm.json
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
"files": ["src/index.js"],
"compilerOptions": {
"declaration": true,
"emitDeclarationOnly": true,
"allowImportingTsExtensions": true,
"allowJs": true,
"checkJs": true,
"outDir": "dist/esm",
Expand Down