Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add typescript support #136

Closed
wants to merge 1 commit into from

Conversation

guillaumearm
Copy link

Hi,

I tested a rc version on a custom repo and it seems to work fine (tested with [email protected])

Let me know if something is missing

@jsf-clabot
Copy link

jsf-clabot commented Feb 18, 2020

CLA assistant check
All committers have signed the CLA.

@btmills
Copy link
Member

btmills commented Feb 26, 2020

👋 Thanks for taking the time to open this pull request, @guillaumearm! The first version of ESlint's processor API didn't have a great solution for extracting code blocks like TypeScript code that aren't plain JS. That's why the hard-coded SUPPORTED_SYNTAXES list had to exist in v1 of this plugin. The good news is that a new processor API shipped in ESLint v6 that will allow this plugin to extract code blocks containing any syntax, and you'll be able to configure what should happen inside your .eslintrc.js without this plugin acting as gatekeeper. I'm now actively working on implementing support for the new API, so if you're still interested in linting TypeScript code inside your Markdown documents, follow #138 for updates. I'll close this now that a first-class supported solution is available and use #138 as the primary tracking issue for that work.

@btmills btmills closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants