-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Type error when importing @eslint/markdown from TypeScript file #313
Comments
Thanks for the issue @danielrentz. Could you maybe create a repro for this problem, like a small GitHub repo or a StackBlitz project, to make sure everybody understands what is going on? It would be interesting to see at least your |
@fasttime I have added stackblitz link and commands in description above. |
Thanks! It looks like the error is being caused by a missing type
Probably we could delete the whole line since the imported type is not used. |
That looks like a holdover from the previous |
@danielrentz as this just involves removing one line, do you want to submit a PR for this change? |
@nzakas Sure! |
fixes eslint#313 Remove typedef for a type not existing in @eslint/core
Same problem here. |
@carlocorradini Release v6.2.2 includes the fix. |
@fasttime Awesome thanks 🙌🥳 |
Environment
ESLint version: 9.18.0
@eslint/markdown version: 6.2.1
Node version: 20.18.1
npm version: 9.8.1
Operating System: Win11
Which language are you using?
commonmark
What did you do?
Import
@eslint/markdown
from a TypeScript file. Do not enable "skipLibChecks" in tsconfig.json.What did you expect to happen?
No type error.
What actually happened?
Link to Minimal Reproducible Example
https://stackblitz.com/edit/vitejs-vite-1rcyxw5v
Participation
Additional comments
No response
The text was updated successfully, but these errors were encountered: