Conversation
This was referenced Jan 1, 2026
Merged
There was a problem hiding this comment.
Pull request overview
This PR exports all types from src/types.ts through the main entry point @eslint/json and removes the /types export path, simplifying the module structure. This change aligns with patterns used in the markdown repository and allows users to import all types from a single location.
Changes:
- Exported types from the main entry point by adding
export * from "./types.js"insrc/index.js - Removed the
/typesexport path frompackage.json - Created a dummy
src/types.jsfile to enable TypeScript to compile the type exports - Updated test imports to import types from
@eslint/jsoninstead of@eslint/json/types
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.js | Added re-export of types from types.js to make them available from the main entry point |
| src/types.js | New dummy file that exports an empty object to bridge the gap between TypeScript source and compiled output |
| package.json | Removed the /types export entry since types are now available from the main entry point |
| tests/types/types.test.ts | Updated imports to use @eslint/json instead of @eslint/json/types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've exported all types from
src/types.tsthrough the main entry point and removed/typesexport.This PR aligns with the approach used in the Markdown repository in eslint/markdown#520 and eslint/markdown#564.
Previously, to access the global types defined in
src/types.ts, they had to be imported from@eslint/json/types. After this change, they can be imported directly from@eslint/json.Also, I've removed the
/typesexport, since the types are now re-exported by the main entry point.What changes did you make? (Give an overview)
To enable importing types from the main entry point, I used a small trick.
The
types.tsfile is built intotypes.jsandtypes.d.ts.In the built
types.js, it's possible to re-export the type declarations from the main entry point usingexport * from "types.js".However, that wasn't possible in the source. To bridge the gap, I added a dummy
src/types.jsfile so types can be imported fromsrc/types.ts.Related Issues
/typesexport css#353/typesexport markdown#564Is there anything you'd like reviewers to focus on?
N/A