refactor: use defaultOptions in no-unnormalized-keys

[lumirlumir]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

In this PR, I've updated the no-unnormlized-keys rule to use defaultOptions.

Previously, the rule used custom logic to extract its default value.

According to MDN and @types/node, the default value for String.prototype.normalize is "NFC", so I've set it as the default.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize#parameters

What changes did you make? (Give an overview)

I've updated the no-unnormlized-keys rule to use defaultOptions.

Related Issues

N/A

Is there anything you'd like reviewers to focus on?

N/A

[mdjermanovic]

LGTM, thanks!

[aladdin-add]

would it be a breaking change? the doc says, "This plugin requires ESLint v9.6.0 or higher", but meta.defaultOptions was added in v9.15.0: https://github.com/eslint/eslint/releases/tag/v9.15.0

[lumirlumir]

Hmm, I'm not sure about this 🤔

But since the sort-keys rule is already using defaultOptions as shown below, and @eslint/json is still in the 0.X unstable version, I think it would be safe. Also, we don't have peerDependencies in the package.json specifying the relevant eslint version, so maybe it's fine?

json/src/rules/sort-keys.js

Lines 99 to 107 in 76cd647

	defaultOptions: [
	"asc",
	{
	allowLineSeparatedGroups: false,
	caseSensitive: true,
	minKeys: 2,
	natural: false,
	},
	],

Or maybe just updating the documentation would be the best approach here?

[aladdin-add]

IMHO, the safest approach is to avoid using defaultOptions - we can update these in next major (dropping eslint <9.15).

[mdjermanovic]

would it be a breaking change? the doc says, "This plugin requires ESLint v9.6.0 or higher", but meta.defaultOptions was added in v9.15.0: https://github.com/eslint/eslint/releases/tag/v9.15.0

Good catch!

Well, since this plugin is technically incompatible with eslint < 9.15 since v0.10.0 when we added the json/sort-keys rule with implementation that needs the defaultOption feature to work properly, maybe we could just update the docs now. @eslint/eslint-tsc thoughts?

[fasttime]

maybe we could just update the docs now.

Yes, at a minimum the docs should be updated.