Merged
Conversation
lumirlumir
approved these changes
Feb 20, 2026
Member
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would it be okay to use fix as the PR prefix? Based on the discussion in eslint/workflows#33 (comment), it seems dependencies updates are treated as fix.
Member
Author
|
Makes sense, I wasn't aware of that. Also, per the description on https://github.com/acornjs/acorn/releases/tag/8.16.0, some bug fixes related to parsing are now released in acorn v8.16.0, so those fixes apply to espree's parsing as well. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Recently release acorn v8.16.0 changes some parsing error messages, and that breaks our tests (https://github.com/eslint/js/actions/runs/22198873458/job/64206263995).
What changes did you make? (Give an overview)
Updated
acorndependency to the latest version and updated failing tests.Related Issues
Is there anything you'd like reviewers to focus on?