Skip to content

fix: update acorn, fix tests#731

Merged
mdjermanovic merged 1 commit intomainfrom
acorn-v8.16.0
Feb 20, 2026
Merged

fix: update acorn, fix tests#731
mdjermanovic merged 1 commit intomainfrom
acorn-v8.16.0

Conversation

@mdjermanovic
Copy link
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Recently release acorn v8.16.0 changes some parsing error messages, and that breaks our tests (https://github.com/eslint/js/actions/runs/22198873458/job/64206263995).

What changes did you make? (Give an overview)

Updated acorn dependency to the latest version and updated failing tests.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 20, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Feb 20, 2026
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would it be okay to use fix as the PR prefix? Based on the discussion in eslint/workflows#33 (comment), it seems dependencies updates are treated as fix.

@lumirlumir lumirlumir moved this from Triaging to Merge Candidates in Triage Feb 20, 2026
@mdjermanovic
Copy link
Member Author

Makes sense, I wasn't aware of that. Also, per the description on https://github.com/acornjs/acorn/releases/tag/8.16.0, some bug fixes related to parsing are now released in acorn v8.16.0, so those fixes apply to espree's parsing as well.

@mdjermanovic mdjermanovic changed the title chore: update acorn, fix tests fix: update acorn, fix tests Feb 20, 2026
@mdjermanovic mdjermanovic merged commit 883d4cc into main Feb 20, 2026
19 checks passed
@mdjermanovic mdjermanovic deleted the acorn-v8.16.0 branch February 20, 2026 12:28
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Feb 20, 2026
@eslintbot eslintbot mentioned this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants