refactor: Use @eslint/plugin-kit #18822

nzakas · 2024-08-27T15:04:55Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refactor

What changes did you make? (Give an overview)

Used @eslint/plugin-kit to replace ConfigCommentParser and several helpers classes in SourceCode.

Is there anything you'd like reviewers to focus on?

Note that the error messages are now slightly different (values are trimmed).

netlify · 2024-08-27T15:05:12Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`f144ac9`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/66cf40a70a0fd80008eb3baa

tools/check-rule-examples.js

lib/languages/js/source-code/source-code.js

lib/linter/linter.js

lib/languages/js/source-code/source-code.js

Co-authored-by: Milos Djermanovic <[email protected]>

mdjermanovic · 2024-08-28T15:12:37Z

This is now unused and should be removed to fix the lint error:

eslint/lib/linter/linter.js

Lines 20 to 22 in e0d0ebe

    
           { 
        
               directivesPattern 
        
           } = require("../shared/directives"),

mdjermanovic

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`9.8.0` -> `9.10.0`](https://renovatebot.com/diffs/npm/eslint/9.8.0/9.10.0) | | [@types/eslint](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/eslint) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/eslint)) | devDependencies | patch | [`9.6.0` -> `9.6.1`](https://renovatebot.com/diffs/npm/@types%2feslint/9.6.0/9.6.1) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v9.10.0`](https://github.com/eslint/eslint/releases/tag/v9.10.0) [Compare Source](eslint/eslint@v9.9.1...v9.10.0) #### Features - [`301b90d`](eslint/eslint@301b90d) feat: Add types ([#18854](eslint/eslint#18854)) (Nicholas C. Zakas) - [`bcf0df5`](eslint/eslint@bcf0df5) feat: limit namespace import identifier in id-length rule ([#18849](eslint/eslint#18849)) (ChaedongIm) - [`45c18e1`](eslint/eslint@45c18e1) feat: add `requireFlag` option to `require-unicode-regexp` rule ([#18836](eslint/eslint#18836)) (Brett Zamir) - [`183b459`](eslint/eslint@183b459) feat: add error message for duplicate flags in `no-invalid-regexp` ([#18837](eslint/eslint#18837)) (Tanuj Kanti) - [`c69b406`](eslint/eslint@c69b406) feat: report duplicate allowed flags in `no-invalid-regexp` ([#18754](eslint/eslint#18754)) (Tanuj Kanti) #### Documentation - [`bee0e7a`](eslint/eslint@bee0e7a) docs: update README ([#18865](eslint/eslint#18865)) (Milos Djermanovic) - [`5d80b59`](eslint/eslint@5d80b59) docs: specify that `ruleId` can be `null` in custom formatter docs ([#18857](eslint/eslint#18857)) (Milos Djermanovic) - [`156b1c3`](eslint/eslint@156b1c3) docs: Update README (GitHub Actions Bot) - [`f6fdef9`](eslint/eslint@f6fdef9) docs: Update README (GitHub Actions Bot) - [`a20c870`](eslint/eslint@a20c870) docs: Update README (GitHub Actions Bot) - [`90e699b`](eslint/eslint@90e699b) docs: Update README (GitHub Actions Bot) #### Chores - [`24c3ff7`](eslint/eslint@24c3ff7) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).10.0 ([#18866](eslint/eslint#18866)) (Francesco Trotta) - [`1ebdde1`](eslint/eslint@1ebdde1) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e8fc5bd`](eslint/eslint@e8fc5bd) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.5.0 ([#18848](eslint/eslint#18848)) (renovate\[bot]) - [`343f992`](eslint/eslint@343f992) refactor: don't use `node.value` when removing unused directives ([#18835](eslint/eslint#18835)) (Milos Djermanovic) - [`3db18b0`](eslint/eslint@3db18b0) refactor: Extract FileContext into class ([#18831](eslint/eslint#18831)) (Nicholas C. Zakas) - [`931d650`](eslint/eslint@931d650) refactor: Use [@eslint/plugin-kit](https://github.com/eslint/plugin-kit) ([#18822](eslint/eslint#18822)) (Nicholas C. Zakas) - [`ed5cf0c`](eslint/eslint@ed5cf0c) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.4.0 ([#18829](eslint/eslint#18829)) (Milos Djermanovic) - [`d1f0831`](eslint/eslint@d1f0831) chore: added missing ids ([#18817](eslint/eslint#18817)) (Strek) - [`ec92813`](eslint/eslint@ec92813) refactor: Config class ([#18763](eslint/eslint#18763)) (Nicholas C. Zakas) ### [`v9.9.1`](https://github.com/eslint/eslint/releases/tag/v9.9.1) [Compare Source](eslint/eslint@v9.9.0...v9.9.1) #### Bug Fixes - [`9bde90c`](eslint/eslint@9bde90c) fix: add logic to handle `fixTypes` in `lintText()` ([#18736](eslint/eslint#18736)) (Amaresh S M) #### Documentation - [`4840930`](eslint/eslint@4840930) docs: Update README with version support and clean up content ([#18804](eslint/eslint#18804)) (Nicholas C. Zakas) - [`f61f40d`](eslint/eslint@f61f40d) docs: Update globals examples ([#18805](eslint/eslint#18805)) (Nicholas C. Zakas) - [`241fcea`](eslint/eslint@241fcea) docs: Use and define languages ([#18795](eslint/eslint#18795)) (Nicholas C. Zakas) - [`5dbdd63`](eslint/eslint@5dbdd63) docs: eslint-plugin-markdown -> [@eslint/markdown](https://github.com/eslint/markdown) ([#18797](eslint/eslint#18797)) (Nicholas C. Zakas) - [`c6c8ddd`](eslint/eslint@c6c8ddd) docs: update links to eslint-visitor-keys repo ([#18796](eslint/eslint#18796)) (Francesco Trotta) - [`f981d05`](eslint/eslint@f981d05) docs: Update README (GitHub Actions Bot) - [`b516974`](eslint/eslint@b516974) docs: update links to `eslint/js` repo ([#18781](eslint/eslint#18781)) (Francesco Trotta) - [`fb7a3f5`](eslint/eslint@fb7a3f5) docs: update note for package managers ([#18779](eslint/eslint#18779)) (Jay) #### Chores - [`b0c34d0`](eslint/eslint@b0c34d0) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).9.1 ([#18809](eslint/eslint#18809)) (Francesco Trotta) - [`cd5a0da`](eslint/eslint@cd5a0da) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e112642`](eslint/eslint@e112642) refactor: Extract parsing logic from Linter ([#18790](eslint/eslint#18790)) (Nicholas C. Zakas) - [`0f68a85`](eslint/eslint@0f68a85) chore: use eslint-plugin-yml on yaml files only ([#18801](eslint/eslint#18801)) (Milos Djermanovic) - [`f8d1b3c`](eslint/eslint@f8d1b3c) chore: update dependencies for browser tests ([#18794](eslint/eslint#18794)) (Christian Bromann) - [`aed2624`](eslint/eslint@aed2624) chore: update dependency [@eslint/config-array](https://github.com/eslint/config-array) to ^0.18.0 ([#18788](eslint/eslint#18788)) (renovate\[bot]) - [`5c29128`](eslint/eslint@5c29128) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.4.0 ([#18789](eslint/eslint#18789)) (renovate\[bot]) - [`5d66fb2`](eslint/eslint@5d66fb2) chore: migrate linting workflow to use trunk check meta-linter ([#18643](eslint/eslint#18643)) (Chris Clearwater) - [`bf96855`](eslint/eslint@bf96855) chore: add ids to github issue templates ([#18775](eslint/eslint#18775)) (Strek) ### [`v9.9.0`](https://github.com/eslint/eslint/releases/tag/v9.9.0) [Compare Source](eslint/eslint@v9.8.0...v9.9.0) #### Features - [`41d0206`](eslint/eslint@41d0206) feat: Add support for TS config files ([#18134](eslint/eslint#18134)) (Arya Emami) - [`3a4eaf9`](eslint/eslint@3a4eaf9) feat: add suggestion to `require-await` to remove `async` keyword ([#18716](eslint/eslint#18716)) (Dave) #### Documentation - [`9fe068c`](eslint/eslint@9fe068c) docs: how to author plugins with configs that extend other configs ([#18753](eslint/eslint#18753)) (Alec Gibson) - [`48117b2`](eslint/eslint@48117b2) docs: add version support page in the side navbar ([#18738](eslint/eslint#18738)) (Amaresh S M) - [`fec2951`](eslint/eslint@fec2951) docs: add version support page to the dropdown ([#18730](eslint/eslint#18730)) (Amaresh S M) - [`38a0661`](eslint/eslint@38a0661) docs: Fix typo ([#18735](eslint/eslint#18735)) (Zaina Al Habash) - [`3c32a9e`](eslint/eslint@3c32a9e) docs: Update yarn command for creating ESLint config ([#18739](eslint/eslint#18739)) (Temitope Ogunleye) - [`f9ac978`](eslint/eslint@f9ac978) docs: Update README (GitHub Actions Bot) #### Chores - [`461b2c3`](eslint/eslint@461b2c3) chore: upgrade to `@eslint/[email protected]` ([#18765](eslint/eslint#18765)) (Francesco Trotta) - [`59dba1b`](eslint/eslint@59dba1b) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`fea8563`](eslint/eslint@fea8563) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.3.0 ([#18724](eslint/eslint#18724)) (renovate\[bot]) - [`aac191e`](eslint/eslint@aac191e) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.3.0 ([#18760](eslint/eslint#18760)) (renovate\[bot]) - [`b97fa05`](eslint/eslint@b97fa05) chore: update wdio dependencies for more stable tests ([#18759](eslint/eslint#18759)) (Christian Bromann) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/215 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@eslint/js](https://eslint.org) ([source](https://github.com/eslint/eslint/tree/HEAD/packages/js)) | devDependencies | minor | [`9.9.1` -> `9.10.0`](https://renovatebot.com/diffs/npm/@eslint%2fjs/9.9.1/9.10.0) | --- ### Release Notes <details> <summary>eslint/eslint (@eslint/js)</summary> ### [`v9.10.0`](https://github.com/eslint/eslint/releases/tag/v9.10.0) [Compare Source](eslint/eslint@v9.9.1...v9.10.0) #### Features - [`301b90d`](eslint/eslint@301b90d) feat: Add types ([#18854](eslint/eslint#18854)) (Nicholas C. Zakas) - [`bcf0df5`](eslint/eslint@bcf0df5) feat: limit namespace import identifier in id-length rule ([#18849](eslint/eslint#18849)) (ChaedongIm) - [`45c18e1`](eslint/eslint@45c18e1) feat: add `requireFlag` option to `require-unicode-regexp` rule ([#18836](eslint/eslint#18836)) (Brett Zamir) - [`183b459`](eslint/eslint@183b459) feat: add error message for duplicate flags in `no-invalid-regexp` ([#18837](eslint/eslint#18837)) (Tanuj Kanti) - [`c69b406`](eslint/eslint@c69b406) feat: report duplicate allowed flags in `no-invalid-regexp` ([#18754](eslint/eslint#18754)) (Tanuj Kanti) #### Documentation - [`bee0e7a`](eslint/eslint@bee0e7a) docs: update README ([#18865](eslint/eslint#18865)) (Milos Djermanovic) - [`5d80b59`](eslint/eslint@5d80b59) docs: specify that `ruleId` can be `null` in custom formatter docs ([#18857](eslint/eslint#18857)) (Milos Djermanovic) - [`156b1c3`](eslint/eslint@156b1c3) docs: Update README (GitHub Actions Bot) - [`f6fdef9`](eslint/eslint@f6fdef9) docs: Update README (GitHub Actions Bot) - [`a20c870`](eslint/eslint@a20c870) docs: Update README (GitHub Actions Bot) - [`90e699b`](eslint/eslint@90e699b) docs: Update README (GitHub Actions Bot) #### Chores - [`24c3ff7`](eslint/eslint@24c3ff7) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).10.0 ([#18866](eslint/eslint#18866)) (Francesco Trotta) - [`1ebdde1`](eslint/eslint@1ebdde1) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e8fc5bd`](eslint/eslint@e8fc5bd) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.5.0 ([#18848](eslint/eslint#18848)) (renovate\[bot]) - [`343f992`](eslint/eslint@343f992) refactor: don't use `node.value` when removing unused directives ([#18835](eslint/eslint#18835)) (Milos Djermanovic) - [`3db18b0`](eslint/eslint@3db18b0) refactor: Extract FileContext into class ([#18831](eslint/eslint#18831)) (Nicholas C. Zakas) - [`931d650`](eslint/eslint@931d650) refactor: Use [@eslint/plugin-kit](https://github.com/eslint/plugin-kit) ([#18822](eslint/eslint#18822)) (Nicholas C. Zakas) - [`ed5cf0c`](eslint/eslint@ed5cf0c) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.4.0 ([#18829](eslint/eslint#18829)) (Milos Djermanovic) - [`d1f0831`](eslint/eslint@d1f0831) chore: added missing ids ([#18817](eslint/eslint#18817)) (Strek) - [`ec92813`](eslint/eslint@ec92813) refactor: Config class ([#18763](eslint/eslint#18763)) (Nicholas C. Zakas) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/226 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

nzakas added 2 commits August 27, 2024 11:02

refactor: Extract ConfigCommentParser

5205d5b

refactor: Use @eslint/plugin-kit

9b5555e

nzakas requested a review from a team as a code owner August 27, 2024 15:04

eslint-github-bot bot added the chore This change is not user-facing label Aug 27, 2024

github-actions bot added the core Relates to ESLint's core APIs and features label Aug 27, 2024

nzakas added 2 commits August 27, 2024 11:45

Remove levn

7b35099

Slice off environment-specific portion of JSON error message

2613ec6

mdjermanovic reviewed Aug 28, 2024

View reviewed changes

tools/check-rule-examples.js Outdated Show resolved Hide resolved

mdjermanovic reviewed Aug 28, 2024

View reviewed changes

lib/languages/js/source-code/source-code.js Outdated Show resolved Hide resolved

mdjermanovic reviewed Aug 28, 2024

View reviewed changes

lib/linter/linter.js Outdated Show resolved Hide resolved

mdjermanovic reviewed Aug 28, 2024

View reviewed changes

lib/languages/js/source-code/source-code.js Outdated Show resolved Hide resolved

mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 28, 2024

nzakas and others added 4 commits August 28, 2024 10:47

Update lib/languages/js/source-code/source-code.js

508a88f

Co-authored-by: Milos Djermanovic <[email protected]>

Update lib/linter/linter.js

6bd4b7a

Co-authored-by: Milos Djermanovic <[email protected]>

Update lib/languages/js/source-code/source-code.js

e815eac

Co-authored-by: Milos Djermanovic <[email protected]>

Apply feedback

e0d0ebe

Remove unused variable

f144ac9

mdjermanovic approved these changes Aug 28, 2024

View reviewed changes

mdjermanovic merged commit 931d650 into main Aug 28, 2024
19 checks passed

mdjermanovic deleted the comment-parser branch August 28, 2024 20:26

ekmixon mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.10.0 ekmixon/aquasecurity-cloudsploit#147

Open

This was referenced Sep 28, 2024

[Snyk] Upgrade eslint from 8.7.0 to 9.10.0 WontonSam/style-dictionary#191

Open

[Snyk] Upgrade eslint from 8.57.1 to 9.10.0 WontonSam/cachiman-aws-credentials#55

Open

lholmquist mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#232

Closed

vinitkumar mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.10.0 vinitkumar/node-twitter#353

Open

leoo1992 mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 9.9.0 to 9.10.0 leoo1992/sistema_ponto#85

Merged

This was referenced Oct 1, 2024

[Snyk] Upgrade eslint from 5.16.0 to 9.10.0 WontonSam/rax-components#538

Open

[Snyk] Upgrade eslint from 8.57.1 to 9.10.0 WontonSam/cachitripe-node#88

Open

lholmquist mentioned this pull request Oct 1, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#233

Closed

tygyh mentioned this pull request Oct 2, 2024

[Snyk] Upgrade eslint from 9.3.0 to 9.10.0 tygyh/godot#6

Open

WontonSam mentioned this pull request Oct 2, 2024

[Snyk] Upgrade eslint from 5.16.0 to 9.10.0 WontonSam/rax-components#546

Open

lholmquist mentioned this pull request Oct 2, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#234

Closed

lholmquist mentioned this pull request Oct 3, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#235

Closed

ebiz-markusrissmann mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.10.0 MarkusRissmann-private/githubclient#174

Open

qdraw mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.10.0 qdraw/starsky#1748

Closed

WontonSam mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 8.6.0 to 9.10.0 WontonSam/cachimanmarket-place-goworkspace#36

Open

lholmquist mentioned this pull request Oct 5, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#236

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Use @eslint/plugin-kit #18822

refactor: Use @eslint/plugin-kit #18822

nzakas commented Aug 27, 2024

netlify bot commented Aug 27, 2024 •

edited

Loading

mdjermanovic commented Aug 28, 2024

mdjermanovic left a comment

refactor: Use @eslint/plugin-kit #18822

refactor: Use @eslint/plugin-kit #18822

Conversation

nzakas commented Aug 27, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Aug 27, 2024 • edited Loading

✅ Deploy Preview for docs-eslint canceled.

mdjermanovic commented Aug 28, 2024

mdjermanovic left a comment

Choose a reason for hiding this comment

netlify bot commented Aug 27, 2024 •

edited

Loading