Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fixed a typo (fixes #11999) #12000

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Docs: Fixed a typo (fixes #11999) #12000

merged 1 commit into from
Jul 17, 2019

Conversation

olsonek
Copy link
Contributor

@olsonek olsonek commented Jul 16, 2019

I adjusted a typo to match the description format of found in the Options section.

This rule takes one optional argument ...

@jsf-clabot
Copy link

jsf-clabot commented Jul 16, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 16, 2019
platinumazure
platinumazure approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Note to merger: Prefix commit summary with "Docs: " on merge.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jul 16, 2019
@olsonek
Copy link
Contributor Author

olsonek commented Jul 16, 2019

I'm actually currently working out how to amend my commit message.

@platinumazure
Copy link
Member

@olsonek Thanks, looks good now!

@g-plane g-plane changed the title Fixed a typo (fixes #11999) Docs: Fixed a typo (fixes #11999) Jul 16, 2019
aladdin-add
aladdin-add approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 89412c3 into eslint:master Jul 17, 2019
This was referenced Aug 27, 2019
Merged
Closed
Merged
Merged
This was referenced Sep 12, 2019
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 9, 2019
Open
Open
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 14, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olsonek @jsf-clabot @platinumazure @aladdin-add