fix: suggestion with invalid syntax in no-promise-executor-return rule (

#17812)
eslint · Dec 4, 2023 · 74739c8 · 74739c8
1 parent e0cb960
commit 74739c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/lib/rules/no-promise-executor-return.js b/lib/rules/no-promise-executor-return.js
@@ -209,12 +209,15 @@ module.exports = {
                         });
                     }
 
-                    suggest.push({
-                        messageId: "wrapBraces",
-                        fix(fixer) {
-                            return curlyWrapFixer(sourceCode, node, fixer);
-                        }
-                    });
+                    // Do not suggest wrapping an unnamed FunctionExpression in braces as that would be invalid syntax.
+                    if (!(node.body.type === "FunctionExpression" && !node.body.id)) {
+                        suggest.push({
+                            messageId: "wrapBraces",
+                            fix(fixer) {
+                                return curlyWrapFixer(sourceCode, node, fixer);
+                            }
+                        });
+                    }
 
                     context.report({
                         node: node.body,

diff --git a/tests/lib/rules/no-promise-executor-return.js b/tests/lib/rules/no-promise-executor-return.js
@@ -891,17 +891,14 @@ ruleTester.run("no-promise-executor-return", rule, {
             }]
         },
         {
+
+            // No suggestion since an unnamed FunctionExpression inside braces is invalid syntax.
             code: "() => new Promise(() => function () {});",
             errors: [{
                 messageId: "returnsValue",
                 type: "FunctionExpression",
                 column: 25,
-                suggestions: [
-                    {
-                        messageId: "wrapBraces",
-                        output: "() => new Promise(() => {function () {}});"
-                    }
-                ]
+                suggestions: []
             }]
         },
         {