-
-
Notifications
You must be signed in to change notification settings - Fork 75
docs: Updated CSS Support blog post #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated code examples to match current version requirements Fixes eslint#800
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dwightware4, thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I've left one non-blocking suggestion.
Would like @Tanujkanti4441 and @nzakas to verify before merging.
| ``` | ||
|
|
||
| If you're using [Tailwind](https://tailwindcss.com), you can configure most of the custom syntax using the builtin `tailwindSyntax` object, like this: | ||
| If you're using [Tailwind](https://tailwindcss.com), you can configure the custom syntax using [tailwind-csstree](https://www.npmjs.com/package/tailwind-csstree), like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you're using [Tailwind](https://tailwindcss.com), you can configure the custom syntax using [tailwind-csstree](https://www.npmjs.com/package/tailwind-csstree), like this: | |
| If you're using [Tailwind](https://tailwindcss.com), you can configure the custom syntax using [`tailwind-csstree`](https://www.npmjs.com/package/tailwind-csstree), like this: |
Non-blocking suggestion: I think it would be nice if the package name is wrapped in backticks, like in the README.md of @eslint/css :)
Ref: https://github.com/eslint/css?tab=readme-ov-file#configuring-tailwind-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
0372cd0
Updated with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (Still, would like @nzakas to verify this before merging.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Updated code examples to match current version requirements
Fixes #800
Prerequisites checklist
What is the purpose of this pull request?
Updated code examples provided in this blog post because the old examples are no longer valid and point the reader in the wrong direction.
What changes did you make? (Give an overview)
Changed the examples to match the current examples found in the README file for the relevant configuration.
Related Issues
fixes #800
Is there anything you'd like reviewers to focus on?
N/A