docs: fix predefined configs example in FlatConfig announcement #574
Conversation
…ding to later breaking changes (because Google shows this page) Blog post: https://eslint.org/blog/2022/08/new-config-system-part-2/#using-predefined-configs Issue: eslint/eslint#17488 Latest text taken from: https://eslint.org/docs/latest/use/configure/configuration-files#using-predefined-configurations
|
Hi @vadimcoder!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vadimcoder
changed the title
eslint-github-bot
bot
added
the
documentation
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
If this is the case, it might be better to add a note to the start of this blog post with a link to the latest docs. @nzakas what do you think? |
But the first link in the latest docs is the link to 2022 announcement (part 2) again:
Maybe it's worth replacing the link to Part 2 with the link to Part 1 because part 1 it's more philosophical and will remain relevant for a long time. |
|
I'm fine with updating the blog post so long as we add a note about the update, like we did at the end of this post: https://eslint.org/blog/2023/01/eslint-2022-year-review/ Adding a link to the current docs is probably a good idea, as well. |
|
@vadimcoder all that's left here is just to add a note at the bottom that says this post was updated. Do you want to finish this up? |
|
@vadimcoder Are you still working on this? |
It has been pending for a long time. I have a note at the bottom and it is ready for review now. |
Prerequisites checklist
What is the purpose of this pull request?
The purpose is to update the 2022 FlatConfig announcement according to the latest breaking changes because Google still shows this page in search results.
What changes did you make? (Give an overview)
Aligned the blogpost with the latest docs.
Related Issues
eslint/eslint#17488
Is there anything you'd like reviewers to focus on?
have a good day