-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [playground]alert item add Disabled button. #546
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@zhangenming pls create an issue explaining what problem you are trying to solve and the solution you would like to implement. ESlint team will triage the issue and mark it as accepted if the team agrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it could be useful, but I'd like some other reviews from @eslint/eslint-team before merging.
Co-authored-by: Nicholas C. Zakas <[email protected]>
display: "flex" | ||
}}> | ||
{ fix && ( | ||
<button onClick={() => onFix(message)} className="alert__fix-btn" style={{ "border-radius": 0 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button onClick={() => onFix(message)} className="alert__fix-btn" style={{ "border-radius": 0 }}> | |
<button onClick={() => onFix(message)} className="alert__fix-btn"> |
Pls, avoid inline style. Try to add style to the existing class.
<div style={{ | ||
display: "flex" | ||
}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div style={{ | |
display: "flex" | |
}}> | |
<div className="alert__actions"> |
Pls, avoid inline style. Create a class and add styles to that class.
In the alert.scss
style file:
.alert__actions {
display: flex:
}
Prerequisites checklist
What is the purpose of this pull request?
we can Disabled an rule quickly.
What changes did you make? (Give an overview)
Related Issues
fixes #548
Is there anything you'd like reviewers to focus on?
The css style is a little newbie not perfect sorry