Skip to content

Conversation

@lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've created ci-bun.yml.

This is part of the effort to centralize workflows mentioned in eslint/workflows#4.

The full workflow can be found here: https://github.com/eslint/workflows/blob/main/.github/workflows/ci-bun.yml

What changes did you make? (Give an overview)

In this PR, I've centralized ci-bun.yml.

Related Issues

Refs: eslint/workflows#15, eslint/workflows#4

Is there anything you'd like reviewers to focus on?

N/A


it("should modify path correctly when on Windows", () => {
const env = ShellOps.getModifiedEnv("win32");
if(process.platform === "win32") {
Copy link
Member Author

@lumirlumir lumirlumir Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just wrapped the test cases with an if-else clause, so Windows tests run only on Windows, and Unix tests run on non-Windows environments.

This is because Bun CI fails on Windows, particularly for the Unix tests.

I suspect it's due to the Unix tests relying on a Unix-specific PATH, but they're being run on Windows.


FYI, the previous CI doesn't include Windows environment tests; adding regular tests that target Windows will cause failures.


https://github.com/eslint/eslint-release/actions/runs/18707118578/job/53347191545

Image

Comment on lines +29 to +33
include:
- os: windows-latest
node: lts/*
- os: macOS-latest
node: lts/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Windows and macOS tests for more robust testing.

@lumirlumir lumirlumir marked this pull request as ready for review October 22, 2025 09:28
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it should support bun - the package is only used by eslint team, and I don't think we will use it in a non-Node.js environment.

@lumirlumir lumirlumir force-pushed the ci-create-ci-bun-yml branch from 6e656c1 to cb1496c Compare October 22, 2025 10:53
@lumirlumir
Copy link
Member Author

lumirlumir commented Oct 22, 2025

@aladdin-add If so, would only adding Windows and macOS tests to the existing ci.yml make sense here?

Looking at the test code, the release tool appears to be intended for use across multiple platforms:

describe("getModifiedEnv()", () => {
it("should modify path correctly when on Windows", () => {
const env = ShellOps.getModifiedEnv("win32");
assert.strictEqual(env.PATH, `${NODE_MODULES_PATH};${PATH}`);
});
[
"darwin",
"freebsd",
"linux",
"sunos"
].forEach(platform => {
it(`(with ${platform}) should modify path correctly when on Unix OS`, () => {
const env = ShellOps.getModifiedEnv(platform);
assert.strictEqual(env.PATH, `${NODE_MODULES_PATH}:${PATH}`);
});
});
});

(Also, there seem to be a few repositories that rely on this package?)

https://github.com/eslint/eslint-release/network/dependents

@nzakas
Copy link
Member

nzakas commented Oct 22, 2025

There's no need to test this on bun as it's just a tool for the team's use.

@nzakas nzakas closed this Oct 22, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants