-
Couldn't load subscription status.
- Fork 8
ci: create ci-bun.yml
#84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| it("should modify path correctly when on Windows", () => { | ||
| const env = ShellOps.getModifiedEnv("win32"); | ||
| if(process.platform === "win32") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just wrapped the test cases with an if-else clause, so Windows tests run only on Windows, and Unix tests run on non-Windows environments.
This is because Bun CI fails on Windows, particularly for the Unix tests.
I suspect it's due to the Unix tests relying on a Unix-specific PATH, but they're being run on Windows.
FYI, the previous CI doesn't include Windows environment tests; adding regular tests that target Windows will cause failures.
| include: | ||
| - os: windows-latest | ||
| node: lts/* | ||
| - os: macOS-latest | ||
| node: lts/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Windows and macOS tests for more robust testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it should support bun - the package is only used by eslint team, and I don't think we will use it in a non-Node.js environment.
6e656c1 to
cb1496c
Compare
…ci-create-ci-bun-yml
|
@aladdin-add If so, would only adding Windows and macOS tests to the existing Looking at the test code, the release tool appears to be intended for use across multiple platforms: eslint-release/tests/lib/shell-ops.test.js Lines 28 to 49 in cbc16bb
(Also, there seem to be a few repositories that rely on this package?) https://github.com/eslint/eslint-release/network/dependents |
|
There's no need to test this on bun as it's just a tool for the team's use. |
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've created
ci-bun.yml.This is part of the effort to centralize workflows mentioned in eslint/workflows#4.
The full workflow can be found here: https://github.com/eslint/workflows/blob/main/.github/workflows/ci-bun.yml
What changes did you make? (Give an overview)
In this PR, I've centralized
ci-bun.yml.Related Issues
Refs: eslint/workflows#15, eslint/workflows#4
Is there anything you'd like reviewers to focus on?
N/A