fix: update @eslint/core to v1.0.0 and adjust tests#337
Conversation
|
Counterpart PR in eslint/json: eslint/json#190 |
package.json
Outdated
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@eslint/core": "^0.17.0", | ||
| "@eslint/core": "^1.0.0", |
There was a problem hiding this comment.
Same question as eslint/json#190 (comment). We can clarify there, just wanted to leave a note here as well so that we don't merge until this is clarified.
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies to support ESLint v10 pre-release versions, motivated by type mismatches when upgrading @eslint/core to v1.0.0. The changes prepare the package for ESLint v10 compatibility by updating both the core library and ESLint itself, while temporarily using legacy-peer-deps to handle peer dependency conflicts during the transition period.
- Updated
@eslint/corefrom ^0.17.0 to ^1.0.0 to get ESLint v10 type information - Updated ESLint dev dependency to use v10 pre-release version range
- Added
legacy-peer-deps = trueto.npmrcas temporary workaround for peer dependency conflicts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates @eslint/core to v1.0.0 and ESLint to v10 pre-release range |
| .npmrc | Adds legacy-peer-deps = true flag with TODO comment for post-v10 release removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Per the suggestions from eslint/json#190, I've updated |
|
I've applied the same change as suggested in eslint/json#190 (comment) |
SwetaTanwar
left a comment
There was a problem hiding this comment.
LGTM, leaving it open for 2nd review.
@eslint/core, add legacy-peer-deps, and use ESLint v10@eslint/core to v1.0.0 and adjust tests
|
I've updated the PR at 97f0d04 per the suggestion in eslint/json#190 (comment) |
This comment was marked as resolved.
This comment was marked as resolved.
|
Friendly ping @mdjermanovic and @nzakas |
Prerequisites checklist
What is the purpose of this pull request?
This PR was motivated by eslint/json#187 (comment).
Currently, when updating
@eslint/coreto v1.0.0, CI fails because@eslint/core@1.0.0does not match ESLint v9@eslint/core@1.0.0includes type information for ESLint v10, which causes the type mismatch.So, I've updated ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)When I update ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added thelegacy-peer-depsoption to.npmrc.This change follows the approach in eslint/eslint#20281
What changes did you make? (Give an overview)
In this PR, I've updated
@eslint/core, addlegacy-peer-deps, and use ESLint v10 pre-release.Related Issues
Ref: #327, eslint/json#187 (comment), eslint/eslint#20281
Is there anything you'd like reviewers to focus on?
N/A