fix: correct parent typing for rule visitors #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMartens
reviewed
Oct 29, 2025
| "WhiteSpace:exit": (...args) => testVisitor<WhiteSpace>(...args), | ||
|
|
||
| // Unknown selectors allowed | ||
| "Atrule[name=import]"(node: AtrulePlain, parent: CssNodePlain) {}, |
There was a problem hiding this comment.
The other changes LGTM, thanks.
This is not an "unknown" selector but rather a combined selector.
Can you please update the comment and also add test cases for unknown selectors (e.g. ForStatement, Unknown, ValueNode) and for additional combined selectors (e.g. "Value, Url)", "*", "Block:first-child")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR updates
CSSNodeVisitorso non-root nodes include aparentparameter; for root, only thenodeis passed.What changes did you make? (Give an overview)
Updated
CSSNodeVisitorso non-root nodes include aparentparameter; for root, only the node is passed.Related Issues
Is there anything you'd like reviewers to focus on?