Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import("eslint") doesn't work #9

Merged
merged 4 commits into from
Dec 18, 2021
Merged

fix: import("eslint") doesn't work #9

merged 4 commits into from
Dec 18, 2021

Conversation

aladdin-add
Copy link
Member

fixes #8

@eslint-github-bot eslint-github-bot bot added triage bug Something isn't working labels Dec 16, 2021
@aladdin-add aladdin-add marked this pull request as draft December 16, 2021 04:09
@aladdin-add aladdin-add marked this pull request as ready for review December 16, 2021 06:09
nzakas
nzakas reviewed Dec 17, 2021
View reviewed changes
lib/init/config-file.js Outdated Show resolved Hide resolved
nzakas
nzakas approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I actually thought of the same solution over dinner.

nzakas
nzakas reviewed Dec 17, 2021
View reviewed changes
lib/init/config-file.js Outdated Show resolved Hide resolved
@aladdin-add @nzakas
Update lib/init/config-file.js
ff7f5a2 
Co-authored-by: Nicholas C. Zakas <[email protected]>
nzakas
nzakas approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 48d8025 into main Dec 18, 2021
@nzakas nzakas deleted the issue8 branch December 18, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic Awaiting requested review from mdjermanovic

Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import("eslint") doesn't work
2 participants
@aladdin-add @nzakas