feat: improve shareable config #208

hyperz111 · 2025-10-13T04:19:12Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Improve shareable config (--config flag). Throw if not found, and can use package tag (e.g. my-eslint-config@alpha).

What changes did you make? (Give an overview)

Example: esl-con-rec

Before:

$ node bin/create-config.js --config esl-con-rec
@eslint/create-config: v1.10.0

ℹ The config that you've selected requires the following dependencies:

eslint, esl-con-rec, error@[object Object], @eslint/config-helpers
? Would you like to install them now? › No / Yes

After:

$ node bin/create-config.js --config esl-con-rec
@eslint/create-config: v1.10.0

file:///data/data/com.termux/files/home/gitclone/eslint-create-config/bin/create-config.js:24
        throw error;
                ^

Error: Cannot fetch "esl-con-rec" with error: Not found
    at fetchPeerDependencies (file:///data/data/com.termux/files/home/gitclone/eslint-create-config/lib/utils/npm-utils.js:134:15)
    at ConfigGenerator.calc (file:///data/data/com.termux/files/home/gitclone/eslint-create-config/lib/config-generator.js:294:33)
    at file:///data/data/com.termux/files/home/gitclone/eslint-create-config/bin/create-config.js:52:21

Node.js v24.7.0

Related Issues

N/A

Is there anything you'd like reviewers to focus on?

N/A

lib/utils/npm-utils.js

hyperz111 · 2025-10-13T22:36:59Z

Maybe this is can be a feature instead a fix

Copilot

Pull Request Overview

This PR improves the shareable config functionality by making the system more robust when handling missing or invalid packages, and adds support for package tags. The key changes include switching from npm CLI commands to direct registry API calls and implementing proper error handling.

Key changes:

Replaces npm CLI dependency with direct npm registry API calls for fetching peer dependencies
Implements proper error handling that throws exceptions for missing packages instead of silently returning null
Adds support for package tags using semver resolution

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
lib/utils/npm-utils.js	Refactored fetchPeerDependencies to use npm registry API directly with proper error handling and semver tag support
lib/config-generator.js	Updated to handle the new error-throwing behavior and extract package names properly
tests/utils/npm-utils.spec.js	Updated tests to reflect the new API-based approach and error-throwing behavior

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

lib/utils/npm-utils.js

tests/utils/npm-utils.spec.js

lib/utils/npm-utils.js

lib/config-generator.js

lib/utils/npm-utils.js

aladdin-add · 2025-10-14T06:41:47Z

lib/utils/npm-utils.js

+                `Version "${version}" not found for package "${name}".`
+            );
        }
+        return Object.entries(Object(packageVersion.peerDependencies)).map(


why Object() is used here? Is this to convert packageVersion.peerDependencies to {} when it is undefined?

aladdin-add · 2025-10-14T06:43:30Z

tests/utils/npm-utils.spec.js

+            stub.resolves(mockResponse);

-            assert.isNull(peerDependencies);
+            expect(async () => await fetchPeerDependencies("desired-package")).rejects.toThrowError();


can we use assert.throws() here? For consistency - the other tests are all assert-style.

hyperz111 · 2025-10-15T11:44:40Z

@aladdin-add, this is ok?

hyperz111 · 2025-10-17T22:43:20Z

@aladdin-add, ping

aladdin-add · 2025-10-18T03:42:26Z

lib/utils/npm-utils.js


-    const error = npmProcess.error;
+    try {
+        // eslint-disable-next-line n/no-unsupported-features/node-builtins -- Fallback using built-in fetch


the comment needs an update. :)

lib/utils/npm-utils.js

hyperz111 · 2025-10-18T04:53:33Z

Maybe i should add test for package with version tag.

aladdin-add · 2025-10-18T04:55:20Z

Maybe i should add test for package with version tag.

👍

aladdin-add · 2025-10-19T14:55:43Z

when running --config eslint-config-eslint-x, it output:

PS D:\repos\eslint-org\create-config> node .\bin\create-config.js --config eslint-config-eslint-x    
@eslint/create-config: v1.10.0

file:///D:/repos/eslint-org/create-config/bin/create-config.js:24
        throw error;
        ^

Error: Cannot fetch "eslint-config-eslint-x@latest" with error: Unexpected Error when fetching package `e
slint-config-eslint-x`: Not found                                                                            at fetchPeerDependencies (file:///D:/repos/eslint-org/create-config/lib/utils/npm-utils.js:114:15)   
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async ConfigGenerator.calc (file:///D:/repos/eslint-org/create-config/lib/config-generator.js:295:
27)                                                                                                          at async file:///D:/repos/eslint-org/create-config/bin/create-config.js:52:5

Node.js v25.0.0

the error message seems a bit strange.

hyperz111 · 2025-10-19T15:00:10Z

when running --config eslint-config-eslint-x, it output:

PS D:\repos\eslint-org\create-config> node .\bin\create-config.js --config eslint-config-eslint-x    
@eslint/create-config: v1.10.0

file:///D:/repos/eslint-org/create-config/bin/create-config.js:24
        throw error;
        ^

Error: Cannot fetch "eslint-config-eslint-x@latest" with error: Unexpected Error when fetching package `e
slint-config-eslint-x`: Not found                                                                            at fetchPeerDependencies (file:///D:/repos/eslint-org/create-config/lib/utils/npm-utils.js:114:15)   
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
    at async ConfigGenerator.calc (file:///D:/repos/eslint-org/create-config/lib/config-generator.js:295:
27)                                                                                                          at async file:///D:/repos/eslint-org/create-config/bin/create-config.js:52:5

Node.js v25.0.0

the error message seems a bit strange.

Maybe you're right, so what the Error message we should throw?

aladdin-add · 2025-10-19T15:08:00Z

Cannot fetch "eslint-config-eslint-x@latest" with error: Unexpected Error when fetching package `e
slint-config-eslint-x`

maybe we could revert the change: 122699f?

aladdin-add · 2025-10-19T15:14:34Z

could you also checkout some unresolved comments, otherwise LGTM, thanks! 👍

aladdin-add

💯 LGTM, thanks! leaving it open for 2~3 days for others to review.

hyperz111 added 3 commits October 8, 2025 17:39

fix: improve shareable config

ecdb5fa

throw error (again)

fecf3f3

update test

c2f6259

eslint-github-bot bot added the bug Something isn't working label Oct 13, 2025

eslintbot added this to Triage Oct 13, 2025

github-project-automation bot moved this to Needs Triage in Triage Oct 13, 2025

aladdin-add self-requested a review October 13, 2025 04:31

aladdin-add self-assigned this Oct 13, 2025

aladdin-add moved this from Needs Triage to Implementing in Triage Oct 13, 2025

aladdin-add added the accepted label Oct 13, 2025

aladdin-add reviewed Oct 13, 2025

View reviewed changes

lib/utils/npm-utils.js Outdated Show resolved Hide resolved

hyperz111 added 3 commits October 14, 2025 02:58

move from spawn npm to fetch only

22d042c

update test

bd29368

update config-generator calc function

896baf7

hyperz111 changed the title ~~fix: improve shareable config~~ feat: improve shareable config Oct 13, 2025

eslint-github-bot bot added the feature label Oct 13, 2025

aladdin-add requested a review from Copilot October 14, 2025 01:37

Copilot AI reviewed Oct 14, 2025

View reviewed changes

lib/utils/npm-utils.js Show resolved Hide resolved

lib/utils/npm-utils.js Show resolved Hide resolved

tests/utils/npm-utils.spec.js Outdated Show resolved Hide resolved

aladdin-add reviewed Oct 14, 2025

View reviewed changes

lib/utils/npm-utils.js Show resolved Hide resolved

aladdin-add reviewed Oct 14, 2025

View reviewed changes

lib/config-generator.js Outdated Show resolved Hide resolved

hyperz111 added 2 commits October 14, 2025 10:40

refactor

bfbff1c

refactor (again)

6970f86

aladdin-add reviewed Oct 14, 2025

View reviewed changes

lib/utils/npm-utils.js Show resolved Hide resolved

aladdin-add reviewed Oct 14, 2025

View reviewed changes

refactor error message

122699f

aladdin-add self-requested a review October 16, 2025 03:12

aladdin-add reviewed Oct 18, 2025

View reviewed changes

lib/utils/npm-utils.js Show resolved Hide resolved

update test

cde4824

revert error message

73bea01

clean comments

f7fedc3

aladdin-add approved these changes Oct 20, 2025

View reviewed changes

aladdin-add moved this from Implementing to Second Review Needed in Triage Oct 20, 2025

aladdin-add merged commit 3fccf98 into eslint:main Oct 22, 2025
12 checks passed

github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 22, 2025

github-actions bot mentioned this pull request Oct 21, 2025

chore: release 1.11.0 #201

Merged

Uh oh!

Uh oh!

feat: improve shareable config #208

feat: improve shareable config #208

Uh oh!

Conversation

hyperz111 commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

Uh oh!

Uh oh!

hyperz111 commented Oct 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aladdin-add Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

aladdin-add Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

hyperz111 commented Oct 15, 2025

Uh oh!

hyperz111 commented Oct 17, 2025

Uh oh!

aladdin-add Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hyperz111 commented Oct 18, 2025

Uh oh!

aladdin-add commented Oct 18, 2025

Uh oh!

aladdin-add commented Oct 19, 2025

Uh oh!

hyperz111 commented Oct 19, 2025

Uh oh!

aladdin-add commented Oct 19, 2025

Uh oh!

aladdin-add commented Oct 19, 2025

Uh oh!

aladdin-add left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hyperz111 commented Oct 13, 2025 •

edited

Loading