Skip to content

fix: release-please config#189

Merged
aladdin-add merged 9 commits intomainfrom
issue181
Feb 19, 2026
Merged

fix: release-please config#189
aladdin-add merged 9 commits intomainfrom
issue181

Conversation

@aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Feb 13, 2026

What is the purpose of this pull request?

fixes #181

What changes did you make? (Give an overview)

Update the configuration to align with eslint/css.

Related Issues

Is there anything you'd like reviewers to focus on?

The main difference is the revert of the commit: eslint/css@0d83c26

tested in the fork: aladdin-add#1

Copilot AI review requested due to automatic review settings February 13, 2026 02:17
Comment on lines +18 to +19
with:
token: ${{ secrets.WORKFLOW_PUSH_BOT_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the token - as it's not set in the org.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix failing release-please automation (issue #181) by updating the GitHub Actions workflow and aligning the setup with eslint/css.

Changes:

  • Reworked .github/workflows/release-please.yml to run release-please and publish to npm in a single job based on release_created.
  • Removed the repository’s existing release-please config and manifest files under .github/release-please/.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/release-please.yml Updates the release workflow steps/permissions and npm publish behavior.
.github/release-please/mainfest.json Removes the release-please manifest file (note: filename suggests it may have been a misspelling of manifest).
.github/release-please/config.json Removes the release-please configuration file.
Comments suppressed due to low confidence (2)

.github/release-please/config.json:1

  • This file removal eliminates the repository’s release-please config, but no replacement default config (e.g., release-please-config.json at repo root) is added in this PR. Either restore this config (or add the default-named config file) so the workflow has a release strategy to apply.
    .github/release-please/mainfest.json:1
  • This manifest file is removed, and there’s no .release-please-manifest.json (default location) added elsewhere in the PR. If the goal was to fix a filename mismatch (e.g., mainfest vs manifest), consider renaming/adding the correct manifest rather than deleting it so release-please can track released versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aladdin-add aladdin-add marked this pull request as draft February 13, 2026 02:29
@aladdin-add aladdin-add requested a review from nzakas February 13, 2026 03:07
@aladdin-add aladdin-add marked this pull request as ready for review February 13, 2026 03:08
@nzakas
Copy link
Contributor

nzakas commented Feb 16, 2026

Don't we also need a config file like in eslint/css?
https://github.com/eslint/css/blob/main/release-please-config.json

@aladdin-add
Copy link
Contributor Author

Don't we also need a config file like in eslint/css? https://github.com/eslint/css/blob/main/release-please-config.json

the package was not published to jsr, so I just config it in:

with:
release-type: node
pull-request-title-pattern: "chore: release ${version} 🚀"

Does it make sense?

@aladdin-add
Copy link
Contributor Author

added in 6c4a015.

@aladdin-add
Copy link
Contributor Author

I'm merging it as it's blocking the new release.

@aladdin-add aladdin-add merged commit 2443d10 into main Feb 19, 2026
12 checks passed
@aladdin-add aladdin-add deleted the issue181 branch February 19, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release-please failing on latest commit

3 participants