Conversation
.github/workflows/release-please.yml
Outdated
| with: | ||
| token: ${{ secrets.WORKFLOW_PUSH_BOT_TOKEN }} |
There was a problem hiding this comment.
removing the token - as it's not set in the org.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing release-please automation (issue #181) by updating the GitHub Actions workflow and aligning the setup with eslint/css.
Changes:
- Reworked
.github/workflows/release-please.ymlto run release-please and publish to npm in a single job based onrelease_created. - Removed the repository’s existing release-please config and manifest files under
.github/release-please/.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/release-please.yml | Updates the release workflow steps/permissions and npm publish behavior. |
| .github/release-please/mainfest.json | Removes the release-please manifest file (note: filename suggests it may have been a misspelling of manifest). |
| .github/release-please/config.json | Removes the release-please configuration file. |
Comments suppressed due to low confidence (2)
.github/release-please/config.json:1
- This file removal eliminates the repository’s release-please config, but no replacement default config (e.g.,
release-please-config.jsonat repo root) is added in this PR. Either restore this config (or add the default-named config file) so the workflow has a release strategy to apply.
.github/release-please/mainfest.json:1 - This manifest file is removed, and there’s no
.release-please-manifest.json(default location) added elsewhere in the PR. If the goal was to fix a filename mismatch (e.g.,mainfestvsmanifest), consider renaming/adding the correct manifest rather than deleting it so release-please can track released versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
55bb7c2 to
ca15f95
Compare
|
Don't we also need a config file like in |
the package was not published to jsr, so I just config it in: eslint-plugin-security/.github/workflows/release-please.yml Lines 19 to 21 in d5cb6a7 Does it make sense? |
d5cb6a7 to
6c4a015
Compare
|
added in 6c4a015. |
|
I'm merging it as it's blocking the new release. |
What is the purpose of this pull request?
fixes #181
What changes did you make? (Give an overview)
Update the configuration to align with eslint/css.
Related Issues
Is there anything you'd like reviewers to focus on?
The main difference is the revert of the commit: eslint/css@0d83c26
tested in the fork: aladdin-add#1