Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove param names fixer #146

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Fix/remove param names fixer #146

merged 2 commits into from
Sep 7, 2018

Conversation

adrianmcli
Copy link
Contributor

Fixes #145

What is the purpose of this pull request?

What changes did you make? (Give an overview)

  • Removed fixer code from rules/param-names.js
  • Updated associated tests in __tests__/param-names.js
  • Updated README.md

This was referenced Sep 7, 2018
Closed
Closed
macklinu
macklinu approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Will merge once the build succeeds and deploy a v4.0.1 patch release.

@macklinu macklinu merged commit af28d6f into eslint-community:master Sep 7, 2018
@adrianmcli adrianmcli deleted the fix/remove-param-names-fixer branch September 7, 2018 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macklinu macklinu macklinu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

param-names fixer breaks code functionality
2 participants
@adrianmcli @macklinu