🧹 Remove deprecated rules

[scagood]

Both n/no-hide-core-modules and n/no-unsupported-features are deprecated.

We should probably look to remove those rules.

Participation

• I am willing to submit a pull request for this issue.

[voxpelli]

Shall we make a milestone for the next major release and plan it for then?

[scagood]

I think that would be good!

Let me know what should be done for these kinda things and I will get on it 😁

[voxpelli]

It for sure has to be removed in a major version, so as soon as such PR is merged we are locked into shipping a new major

And common practice is to let a deprecated rule stay for a minimum amount of releases / time with proper alerts, in case that’s done then feel free to create a PR that clears it up + if you can, create a milestone to track next major (the latter thing is a personal preference of mine, the main maintainers of this package may not agree, but I see no harm in doing it)

[scagood]

That makes sense to me!
I know that the docs have said that they've been deprecated for a while.

no-hide-core-modules has been deprecated from v4.2.0 (61fcbb0)

no-unsupported-features has been deprecated from v7.0.0 (58f3120)

We're now on v16.3, I would hope that is enough time! 😂

[voxpelli]

Sounds like it’s very much time 😂

[scagood]

Based on this comment (mysticatea#69 (comment)) I think we should actually consider not removing the no-hide-core-modules rule.

I can see both the use and validity of such problems.