fix: change peer dependencies to allow eslint v9 (#216)

* Revert "fix: explicitly support ESLint 9.0.0 pre-releases (#200)" This reverts commit a5eaa9c. * build: tests on eslint v9 * chore: fix linting errors * chore: fix eslint v9 tests
eslint-community · Apr 7, 2024 · 5e82d7f · 5e82d7f
1 parent d96976d
commit 5e82d7f
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 53 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -33,7 +33,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]
-        eslint: [8.x, "next"]
+        eslint: [8.x, "9.x"]
         node: [18.x, 20.x]
         include:
           - os: ubuntu-latest

diff --git a/lib/rules/file-extension-in-import.js b/lib/rules/file-extension-in-import.js
@@ -24,7 +24,7 @@ function getExistingExtensions(filePath) {
             .readdirSync(directory)
             .filter(filename => filename.startsWith(`${basename}.`))
             .map(filename => path.extname(filename))
-    } catch (_error) {
+    } catch {
         return []
     }
 }

diff --git a/lib/rules/process-exit-as-throw.js b/lib/rules/process-exit-as-throw.js
@@ -30,7 +30,7 @@ function safeRequire(...moduleNames) {
     for (const moduleName of moduleNames) {
         try {
             return require(moduleName)
-        } catch (_err) {
+        } catch {
             // Ignore.
         }
     }

diff --git a/lib/util/get-package-json.js b/lib/util/get-package-json.js
@@ -28,7 +28,7 @@ function readPackageJson(dir) {
             data.filePath = filePath
             return data
         }
-    } catch (_err) {
+    } catch {
         // do nothing.
     }
 

diff --git a/lib/util/get-semver-range.js b/lib/util/get-semver-range.js
@@ -20,7 +20,7 @@ module.exports = function getSemverRange(x) {
     if (!ret) {
         try {
             ret = new Range(s)
-        } catch (_error) {
+        } catch {
             // Ignore parsing error.
         }
         cache.set(s, ret)

diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
         "configs/"
     ],
     "peerDependencies": {
-        "eslint": "^8.23.0 || >=9.0.0-0"
+        "eslint": ">=8.23.0"
     },
     "dependencies": {
         "@eslint-community/eslint-utils": "^4.4.0",
@@ -26,10 +26,10 @@
         "semver": "^7.5.3"
     },
     "devDependencies": {
-        "@eslint/js": "^8.43.0",
+        "@eslint/js": "^9.0.0",
         "@types/eslint": "^8.56.2",
         "@typescript-eslint/parser": "^7.0.0",
-        "eslint": "^8",
+        "eslint": "^9.0.0",
         "eslint-config-prettier": "^9.1.0",
         "eslint-doc-generator": "^1.6.1",
         "eslint-plugin-eslint-plugin": "^5.2.1",

diff --git a/tests/lib/rules/no-unsupported-features/es-builtins.js b/tests/lib/rules/no-unsupported-features/es-builtins.js
@@ -42,14 +42,14 @@ function ignores(keyword) {
 }
 
 function runTests(patterns) {
-    for (const pattern of patterns) {
-        const ruleTester = new RuleTester({
-            languageOptions: {
-                ecmaVersion: "latest",
-                globals: globals.builtin,
-            },
-        })
+    const ruleTester = new RuleTester({
+        languageOptions: {
+            ecmaVersion: "latest",
+            globals: globals.builtin,
+        },
+    })
 
+    for (const pattern of patterns) {
         const tests = {
             valid: pattern.valid,
             invalid: pattern.invalid,

diff --git a/tests/lib/rules/no-unsupported-features/es-syntax.js b/tests/lib/rules/no-unsupported-features/es-syntax.js
@@ -56,11 +56,11 @@ function ignores(keyword) {
 }
 
 function runTests(patterns) {
-    for (const pattern of patterns) {
-        const ruleTester = new RuleTester({
-            languageOptions: { ecmaVersion: "latest", env: { node: false } },
-        })
+    const ruleTester = new RuleTester({
+        languageOptions: { ecmaVersion: "latest", env: { node: false } },
+    })
 
+    for (const pattern of patterns) {
         const tests = {
             valid: pattern.valid,
             invalid: pattern.invalid,
@@ -492,40 +492,42 @@ runTests([
                 code: "(class { key(a = 0) {} })",
                 options: [{ version: "6.0.0" }],
             },
-            {
-                code: "function f(a = 0) {}",
-                options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
-            },
-            {
-                code: "(function(a = 0) {})",
-                options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
-            },
-            {
-                code: "((a = 0) => a)",
-                options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
-            },
-            {
-                code: "({ key(a = 0) {} })",
-                options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
-            },
-            {
-                code: "class A { key(a = 0) {} }",
-                options: [
-                    {
-                        version: "5.9.9",
-                        ignores: ["classes", "defaultParameters"],
-                    },
-                ],
-            },
-            {
-                code: "(class { key(a = 0) {} })",
-                options: [
-                    {
-                        version: "5.9.9",
-                        ignores: ["classes", "defaultParameters"],
-                    },
-                ],
-            },
+
+            // detected duplicate tests by eslint v9
+            // {
+            //     code: "function f(a = 0) {}",
+            //     options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
+            // },
+            // {
+            //     code: "(function(a = 0) {})",
+            //     options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
+            // },
+            // {
+            //     code: "((a = 0) => a)",
+            //     options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
+            // },
+            // {
+            //     code: "({ key(a = 0) {} })",
+            //     options: [{ version: "5.9.9", ignores: ["defaultParameters"] }],
+            // },
+            // {
+            //     code: "class A { key(a = 0) {} }",
+            //     options: [
+            //         {
+            //             version: "5.9.9",
+            //             ignores: ["classes", "defaultParameters"],
+            //         },
+            //     ],
+            // },
+            // {
+            //     code: "(class { key(a = 0) {} })",
+            //     options: [
+            //         {
+            //             version: "5.9.9",
+            //             ignores: ["classes", "defaultParameters"],
+            //         },
+            //     ],
+            // },
         ],
         invalid: [
             {