Build: test on eslint v8 (fixes #175) #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgrading eslint-plugin-unicorn should fix this since I believe they were previously accessing APIs that are no longer public in ESLint 8: #187 |
aladdin-add
force-pushed
the
support-eslint-v8
branch
from
cabceca
to
bd074ef
Compare
|
looks like the latest eslint-plugin-unicorn does not play well with eslint 8.0.0. the cause is: |
aladdin-add
commented
Sep 26, 2021
| "eslint-config-not-an-aardvark": "^2.1.0", | ||
| "eslint-plugin-markdown": "^2.0.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-self": "^1.2.1", | ||
| "eslint-plugin-unicorn": "^36.0.0", | ||
| "eslint-plugin-unicorn": "github:fisker/eslint-plugin-unicorn#eslint-8", |
There was a problem hiding this comment.
TODO: replace the fork once it get merged and released.
There was a problem hiding this comment.
I think we can proceed with this fork for now:
- Most importantly, eslint-plugin-unicorn is an internal-only dev-dependency, and we shouldn't let a non-essential dev-dependency that has no public-facing impact to our consumers block us from releasing our plugin
- The fork is owned by the maintainer of eslint-plugin-unicorn
- We can pin to a specific commit of the fork branch if desired
- Other repositories are using this fork to unblock themselves while awaiting for the official fix to be released
There was a problem hiding this comment.
fine, let's do it!
|
just pushed a commit db7131e to upgrade dev deps: espree & eslint-scope. |
bmish
approved these changes
Sep 26, 2021
bmish
reviewed
Sep 26, 2021
This was referenced Sep 27, 2021
Closed
This was referenced Oct 10, 2021
bmish
reviewed
Oct 10, 2021
36 tasks
Co-authored-by: Bryan Mishkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.