Breaking: Add meta.hasSuggestions property to meta-property-ordering rule
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
changed the title
meta.hasSuggestions property to meta-property-ordering rulemeta.hasSuggestions property to meta-property-ordering rule
|
it seems a breaking change to change the default options. :) |
This was referenced Aug 23, 2021
Closed
13 tasks
50 tasks
aladdin-add
approved these changes
Sep 24, 2021
|
we need to resolve the conflicts. :) |
It makes most sense to order the new ESLint 8 property `meta.hasSuggestions` after the related property `meta.fixable`. https://eslint.org/blog/2021/06/whats-coming-in-eslint-8.0.0#rules-with-suggestions-now-require-the-metahassuggestions-property
bmish
force-pushed
the
meta-property-ordering-hasSuggestions
branch
from
04218b2
to
62716a4
Compare
This was referenced Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes most sense to order the new ESLint 8 property
meta.hasSuggestions(whether a rule provides suggestions) after the related propertymeta.fixable(whether a rule is autofixable).https://eslint.org/blog/2021/06/whats-coming-in-eslint-8.0.0#rules-with-suggestions-now-require-the-metahassuggestions-property