Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatically building wheels on Linux and Mac #322

Closed
wants to merge 9 commits into from
Closed

Conversation

dfm
Copy link

@dfm dfm commented Apr 13, 2021

This PR adds a GitHub actions workflow that uses cibuildwheel to automatically build binary wheels for the standard Linux and Mac platforms. These wheels could be uploaded to PyPI manually or uploaded automatically (this is what I do with most of my projects). This would help with issues like #298 (because it packages all of the dependencies) and generally speed up pip-based dependency workflows, but some users might prefer to tune their cfitsio, and it adds some developer overhead, so you should definitely feel free to veto/ignore/etc.!

Also, I'll be happy to squash/rebase to clean up the history if this is something that you're interested in merging.

@beckermr
Copy link
Collaborator

I don't personally want to maintain this, but I'll leave the final say to @esheldon.

@esheldon
Copy link
Owner

Thanks @dfm

I don't know anything about wheels. I certainly could not maintain this.

How does this affect publishing to pypi or conda forge?

@dfm
Copy link
Author

dfm commented Apr 25, 2021

@esheldon, @beckermr: Thanks - I would find this a useful feature since I mostly use pip to manage my dependencies rather than conda, but I don't want to add extra maintenance burden! I think probably the best bet is to just close this if you aren't feeling comfortable with such a feature. Thanks for the consideration!

@esheldon: to answer your questions: I use a workflow like this to automatically publish to PyPI (both source and binary builds) on a tagged GitHub release (for example). It would not have any affect on conda/conda-forge whatsoever.

@dfm dfm closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants