[QuickDialogTableView] Set root only after data source and delegate are set #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 9 calls reloadData less agressively than iOS 8 and earlier. If the root of the table view is set too soon (eg. before the data source is set), reloadData may not be called in certain cases, resulting in inconsistencies and inducing crashes.
|
@escoz I had the crash in another app, this is pretty critical. |
|
The logic issue fixed here is easy to understand: setting the root property causes |
sjrmanning
pushed a commit
to Adapptor/QuickDialog
that referenced
this pull request
Nov 4, 2015
… delegate are set before setting root. See escoz#720
|
@escoz - Could you guys please try and merge this. This is fairly a critical issue considering number of devices using iOS 9 now. |
|
@escoz - I am also seeing a crash due to this issue. It would be great if it could be merged in. |
escoz
added a commit
that referenced
this pull request
Nov 4, 2015
[QuickDialogTableView] Set root only after data source and delegate are set
|
Done! Thanks guys, sorry for the delay, it's been busy lately. |
khowardui
added a commit
to dxt/QuickDialog
that referenced
this pull request
Apr 26, 2017
abarisain
added a commit
to abarisain/QuickDialog
that referenced
this pull request
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS 9 calls
reloadDataless agressively than iOS 8 and earlier. If the root of the table view is set too soon (eg. before the data source is set),reloadDatamay not be called in certain cases, resulting in inconsistencies and inducing crashes.