Skip to content

Conversation

@c-martinez
Copy link
Contributor

No description provided.

- Developer
- [Citation](https://the-turing-way.netlify.app/communication/citable/citable-cff.html#cm-citable-cff)
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)
Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first link is not working for me.

@JaroCamphuijsen
Copy link
Collaborator

I like that you added these resources, should they also be part of the licensing module? @LourensVeen

@LourensVeen
Copy link
Collaborator

Good idea! I'm biased though 😄

- Developer
- [Citation](https://the-turing-way.netlify.app/communication/citable/citable-cff.html#cm-citable-cff)
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)
- [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html)

Maybe should be this one

Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@c-martinez
Copy link
Contributor Author

Looks like @JaroCamphuijsen still needs to approve it?

@ewan-escience
Copy link
Collaborator

Can we change it so that reviewers who request changes don't block the PR if at least one approval is given? People on this project don't typically seem to have much time for rereviewing PRs.

@c-martinez
Copy link
Contributor Author

Is it possible to change that rule? I can "Merge without waiting for requirements to be met (bypass rules)" -- which I guess is kind of the same?

@ewan-escience
Copy link
Collaborator

That's what you can do to merge it now indeed (I don't have the appropriate permissions).

@c-martinez c-martinez merged commit ffa4a96 into main Oct 20, 2025
1 check passed
@c-martinez c-martinez deleted the smp-reading branch October 20, 2025 11:22
@c-martinez
Copy link
Contributor Author

Ok, I've bypassed the rule (not ideal, but ok) -- thanks all for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants