-
Notifications
You must be signed in to change notification settings - Fork 4
Adding SMP recommended reading #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - Developer | ||
| - [Citation](https://the-turing-way.netlify.app/communication/citable/citable-cff.html#cm-citable-cff) | ||
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) | ||
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first link is not working for me.
|
I like that you added these resources, should they also be part of the licensing module? @LourensVeen |
|
Good idea! I'm biased though 😄 |
| - Developer | ||
| - [Citation](https://the-turing-way.netlify.app/communication/citable/citable-cff.html#cm-citable-cff) | ||
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) | ||
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-software.html) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) | |
| - [Software licensing](https://the-turing-way.netlify.app/reproducible-research/licensing) and [compatibility](https://the-turing-way.netlify.app/reproducible-research/licensing/licensing-compatibility.html) |
Maybe should be this one
LourensVeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
Looks like @JaroCamphuijsen still needs to approve it? |
|
Can we change it so that reviewers who request changes don't block the PR if at least one approval is given? People on this project don't typically seem to have much time for rereviewing PRs. |
|
Is it possible to change that rule? I can "Merge without waiting for requirements to be met (bypass rules)" -- which I guess is kind of the same? |
|
That's what you can do to merge it now indeed (I don't have the appropriate permissions). |
|
Ok, I've bypassed the rule (not ideal, but ok) -- thanks all for your feedback! |
No description provided.