Skip to content

feat(skills): admin skills management parity (#58)#68

Merged
mpge merged 3 commits into
mainfrom
feat/admin-skills-management
May 17, 2026
Merged

feat(skills): admin skills management parity (#58)#68
mpge merged 3 commits into
mainfrom
feat/admin-skills-management

Conversation

@mpge
Copy link
Copy Markdown
Member

@mpge mpge commented May 17, 2026

Summary

  • Adds SkillRoutingTag / SkillRoutingDepartment pivots plus AgentSkill surrogate key, int proficiency (1–5), timestamps, and check constraint wired through shared EscalatedModelConfiguration plus handcrafted SkillManagementParity migration (SQLite / PostgreSQL / SQL Server agent_skill reshaping with legacy string backfill).
  • Introduces /support/admin/skills admin JSON endpoints (transactions on writes) and refactors SkillRoutingService to require agents to cover every matched routed skill while ranking by summed proficiency then open workload.
  • Adds tests for admin skills endpoints, routing, and legacy proficiency string mapping aligned with migration backfill rules.

Test plan

  • dotnet build (not run here — dotnet CLI unavailable in this environment).
  • dotnet test
  • dotnet format --verify-no-changes

Closes escalated-dotnet#58.

Add explicit tag/department skill routing pivots, Agent surrogate key with 1..5 proficiency
and timestamps (plus migration paths for SQLite/PostgreSQL/SQL Server), refactor
SkillRoutingService for all-required-skills routing, and admin REST endpoints under
/support/admin/skills.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mpge mpge force-pushed the feat/admin-skills-management branch from cf45b93 to a78b022 Compare May 17, 2026 16:52
@mpge
Copy link
Copy Markdown
Member Author

mpge commented May 17, 2026

Reviewed: skills parity for #58. Cursor delivered the explicit-mapping routing tables, proficiency migrated from string enum (beginner|intermediate|expert) to int 1..5 with the LegacySkillProficiency lookup for backfill, transactional admin controller, and full test coverage.

Manual fixes applied during review:

  • rebase onto current main (EF Core 9.0.16) and bump the new Microsoft.EntityFrameworkCore.Design dep to 9.0.16
  • add missing closing brace on SkillManagementParity.cs
  • add using Microsoft.EntityFrameworkCore.Infrastructure; so the [DbContext] attribute resolves

CI green: lint + test both pass on the latest commit. Merging.

@mpge mpge merged commit da8e26f into main May 17, 2026
2 checks passed
@mpge mpge deleted the feat/admin-skills-management branch May 17, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant