Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Emit compile errors instead of crashing. #38

Merged
merged 2 commits into from
Dec 4, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ function hbsfy(file, opts) {
buffer += chunk.toString();
},
function() {
var js = precompiler.precompile(buffer, opts && opts.precompilerOptions);
var js;
try {
js = precompiler.precompile(buffer, opts && opts.precompilerOptions);
} catch (e) {
this.emit('error', e);
return this.queue(null);
}
// Compile only with the runtime dependency.
var compiled = "// hbsfy compiled Handlebars template\n";
compiled += "var HandlebarsCompiler = " + compiler + ";\n";
Expand Down
1 change: 1 addition & 0 deletions test/error.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{{#error}}
12 changes: 12 additions & 0 deletions test/error_test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

var fs = require("fs");
var hbsfy = require("hbsfy");

var templatePath = __dirname + "/error.hbs";

fs.createReadStream(templatePath)
.pipe(hbsfy(templatePath))
.on('error', function () {
// Error handled, so we will not crash.
});