Fdtd fixes #110
Fdtd fixes #110
Conversation
- Added function to eliminate transient parts in the FDTD signal output - Added notebook to compare
Updated paper results notebooks
| @@ -100,7 +107,7 @@ def plot_spectrum( | |||
| target_frequencies, | |||
| R_spectrum, | |||
| ylimits, | |||
| 121, | |||
There was a problem hiding this comment.
What is this number?
There was a problem hiding this comment.
It defines the index of the plot among the subplots
| @@ -38,15 +208,14 @@ def calculate_transmission_reflection_coefficients( | |||
| .item() | |||
| ] | |||
| ) | |||
|
|
|||
| else: | |||
There was a problem hiding this comment.
May want to remove this, as the results could possibly be way off, and rather ask that the user uses more time steps? Will probably be unnecessary with the automatic calculation of niter
There was a problem hiding this comment.
But we already asking them to increase the number of timesteps, right? Regarding automatic calculation see also https://github.com/esa/NIDN/pull/111/files#r935248046 . I think we should tell the user to do it. Our calculation may be off or the user is just testing something, wants to use fewer timesteps some reason etc. Always forcibly increasing it limits the use options
Description
Summary of changes
Need to
Resolved Issues
N/A
How Has This Been Tested?
Related Pull Requests
N/A