Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowed option #25

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Add allowed option #25

merged 2 commits into from
Jun 27, 2024

Conversation

zloirock
Copy link
Contributor

Fixes #23

@43081j
Copy link
Contributor

43081j commented Jun 27, 2024

can you add a test or two too? 👀

particularly:

  • setting allowed with a match in modules
  • setting allowed with a match in a preset

@zloirock
Copy link
Contributor Author

Done.

43081j
43081j approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work here 🥳

looks good to me

@43081j 43081j merged commit ab4718d into es-tooling:main Jun 27, 2024
3 checks passed
@zloirock zloirock deleted the allowed-option branch June 27, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option for allowing some "banned" dependencies
2 participants
@zloirock @43081j