Add support for ARM builds #278
Conversation
|
Good stuff 👍.
|
There was a problem hiding this comment.
I don't have full knowledge of how Bob's generating the builds (or where) so trust @ericmj's judgement. My approval is for the overall structure of the rest of change, even though I understand we may not have GitHub-hosted runners in ARM.
|
I've approved the test run, but there's a failing test: https://github.com/erlef/setup-beam/actions/runs/9316480861/job/25657891440?pr=278#step:6:55. It seems unrelated to the proposed changes (and it passes in the main branch: I just re-executed it there). @favrik, could you rebase your branch over |
|
Thanks for the reviews!! I'm testing on an ARM64 self-hosted runner. There is an issue with the current version of the code, but already solved, will update PR and tests soon. The issue: the OS Architecture information is needed in different functions: |
I'd say "whatever means less code". From a functional perspective, though, and since this is not a time-critical path, I'd probably go with using the function. (though I haven't tried the code, so don't quite know how it'd look) Btw, tests are failing, but I'm not sure those are the ones you're referring to 😄 |
|
Re-ran the tests just now. They're still failing. I didn't look into the "why". |
|
Updated: verified tests run without errors on Ubuntu, and added updated logic to actually make it work in self-hosted runners with ARM64 arch. |
| spec = '26' | ||
| osVersion = 'ubuntu-24.04' | ||
| expected = 'maint-26' | ||
| got = await setupBeam.getOTPVersion(spec, osVersion, hexMirrors) |
There was a problem hiding this comment.
I think this hexMirrors is wrong everywhere. Would you be so kind and remove it? (at least, from your changes, but also from all the other tests if it's Ok with you) Thanks.
There was a problem hiding this comment.
I'll merge as-is and do the fix, no worries.
|
Thanks, @favrik. I'm merging this. Should get released soon after two minor pull requests are accepted/merged. |
Description
Support new OTP builds for ARM64: https://github.com/hexpm/bob/pull/174/files. Ubuntu 16.04 and 18.04 do not appear to have ARM64 builds.