Update tested software versions as to not have CI fail (while fixing "non-failing" CI) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it silently fails with "Error: Requested Erlang/OTP version (23.2) not found in version list (should you be using option 'version-type': 'strict'?)", which is not too important since this happens when setup-beam.js is included (which happens in the test environment only)
I think `gleam check` requires OTP (execution complains about missing `escript`) where `gleam format` does not
starbelly
approved these changes
Dec 12, 2022
|
This was merged sooner than I expected 😄 I'd left a comment for @lpil in the linked issue, but maybe it's not warranted any more. |
paulo-ferraz-oliveira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently found that CI wasn't "failing as it should". I'm opening this PR as a draft to be able to identify the failing elements, then fix potentially them, then convert to "Ready for review".
Also closes #165.