Update README: signal OTP-25 as a working version #122
Conversation
|
Hey, @kianmeng. Thanks for this. It seems the tests don't fully cover your changes, though, in terms of base container. Could you probably add some so they do? |
|
@paulo-ferraz-oliveira You meant tests in this file, https://github.com/erlef/setup-beam/blob/main/__tests__/setup-beam.test.js for OTP 25? |
|
Sorry, yeah, I should've been more explicit. They should be added to https://github.com/erlef/setup-beam/blob/main/.github/workflows/ubuntu.yml, one entry Ubuntu / Erlang version, where they don't exist. Thanks. |
kianmeng
force-pushed
the
update-otp-25-to-readme
branch
from
e75f4a4 to
e2abd3b
Compare
|
@paulo-ferraz-oliveira Done. By the way, do we have any sorting order for the matrix combo in https://github.com/erlef/setup-beam/blob/main/.github/workflows/ubuntu.yml? |
|
Hi, @kianmeng. I'll make the actions run. No particular sorting order, I believe. Thanks. |
|
Thanks for your update, @kianmeng. Merging... |
paulo-ferraz-oliveira
changed the title
|
🥳 🥳 🥳 🥳 🥳 |
See #118