Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease contributions with npm run build-dist #109

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Ease contributions with npm run build-dist #109

merged 2 commits into from
Apr 21, 2022

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Fix #107
Fix #108

I end up fixing the licenses.txt issue because this was getting generated locally (for no reason) and pollutes the checks.

We already have everything we need in 3RD_PARTY_LICENSES
Copy link
Member

@starbelly starbelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 9d4fdad into erlef:main Apr 21, 2022
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/run-build-dist branch April 22, 2022 21:59
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Feature/run build dist npm run build-dist (ease contributions) Apr 23, 2022
@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title npm run build-dist (ease contributions) Ease contributions with npm run build-dist Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "build" target to package.json (or add a Makefile) Get rid of licenses.txt under dist/
2 participants