Crash on invalid Elixir+OTP combo (#134)

* Prevent "future" errors when choosing incompatible Elixir v. OTP versions * Fix tests as per GitHub Actions' output * Make test elixir `master` strict It has no -otp- in the name
erlef · Sep 13, 2022 · 6b2f815 · 6b2f815
1 parent 7dd0d76
commit 6b2f815
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -116,6 +116,7 @@ jobs:
           - elixir-version: 'master'
             otp-version: '25'
             os:  'ubuntu-20.04'
+            version-type: 'strict'
           - gleam-version: 'nightly'
             otp-version: '24'
           - gleam-version: '0.23'

diff --git a/__tests__/setup-beam.test.js b/__tests__/setup-beam.test.js
@@ -171,8 +171,8 @@ async function testElixirVersions() {
   let otpVersion
 
   spec = '1.1.x'
-  otpVersion = 'OTP-23'
-  expected = 'v1.1.1'
+  otpVersion = 'OTP-17'
+  expected = 'v1.1.1-otp-17'
   got = await setupBeam.getElixirVersion(spec, otpVersion)
   assert.deepStrictEqual(got, expected)
 

diff --git a/dist/index.js b/dist/index.js
@@ -7358,9 +7358,11 @@ async function getElixirVersion(exSpec0, otpVersion) {
         `Using Elixir ${elixirVersion} (built for OTP ${otpVersionMajor})`,
       )
     } else {
-      // ... and it's not available: fallback to the 'generic' version (v1.4.5 only).
-      elixirVersionWithOTP = elixirVersion
-      core.info(`Using Elixir ${elixirVersion}`)
+      // ... and it's not available: exit with exception
+      throw new Error(
+        `Requested Elixir / Erlang/OTP version (${exSpec0} / ${otpVersion}) not ` +
+          'found in version list (did you check Compatibility between Elixir and Erlang/OTP?)',
+      )
     }
   } else {
     throw new Error(

diff --git a/src/setup-beam.js b/src/setup-beam.js
@@ -188,9 +188,11 @@ async function getElixirVersion(exSpec0, otpVersion) {
         `Using Elixir ${elixirVersion} (built for OTP ${otpVersionMajor})`,
       )
     } else {
-      // ... and it's not available: fallback to the 'generic' version (v1.4.5 only).
-      elixirVersionWithOTP = elixirVersion
-      core.info(`Using Elixir ${elixirVersion}`)
+      // ... and it's not available: exit with exception
+      throw new Error(
+        `Requested Elixir / Erlang/OTP version (${exSpec0} / ${otpVersion}) not ` +
+          'found in version list (did you check Compatibility between Elixir and Erlang/OTP?)',
+      )
     }
   } else {
     throw new Error(