Bump hex_core and certifi dependency #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh not sure why CI implodes here, will have to dig a bit. |
ferd
force-pushed
the
bump-hex-core-and-deps
branch
from
9bbac79 to
2b92ff7
Compare
This required some manual patching of the gpb plugin and lib versions but the rest is unchanged. Also the min version gets bumped to OTP-25, and some adapting was required in `rebar_packages` due to a format change.
ferd
force-pushed
the
bump-hex-core-and-deps
branch
from
2b92ff7 to
53a0316
Compare
ferd
commented
Jun 11, 2024
| @@ -246,7 +246,8 @@ update_package(Name, RepoConfig=#{name := Repo}, State) -> | |||
| ?DEBUG("Getting definition for package ~ts from repo ~ts", | |||
| [Name, rebar_hex_repos:format_repo(RepoConfig)]), | |||
| try r3_hex_repo:get_package(get_package_repo_config(RepoConfig), Name) of | |||
| {ok, {200, _Headers, Releases}} -> | |||
| {ok, {200, _Headers, Package}} -> | |||
| #{releases := Releases} = Package, | |||
There was a problem hiding this comment.
|
Currently checking with @starbelly to see whether this would have any effect on the hex plugin for publishing packages. |
Confirmed that it's safe, both projects use different "versions" of the lib due to our vendoring in here. |
starbelly
approved these changes
Jun 12, 2024
tsloughter
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions were very out of date, this was overdue.
Related hex_core PR for some clean-up I did while around there: hexpm/hex_core#146