Defer hostname check to OTP when supported #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating the work required to support erlang#2803, I found out that the code was already in place. However, despite the code being there, we still passed the old `ssl_verify_hostname:verify_fun/3` function of pre-21.0 on top of it, which I supposed ignored the check. So this change reworks the flow such that we fall back to the legacy check only if it isn't supported by the OTP library at this point. Getting this going would require someone to build a new release on an Erlang copy older than OTP-21 (which is no longer supported) which is unlikely. This follows guidelines from https://erlef.github.io/security-wg/secure_coding_and_deployment_hardening/ssl
tsloughter
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the work required to support
#2803, I found out that the code was already in place.
However, despite the code being there, we still passed the old
ssl_verify_hostname:verify_fun/3function of pre-21.0 on top of it, which I supposed ignored the check.So this change reworks the flow such that we fall back to the legacy check only if it isn't supported by the OTP library at this point. Getting this going would require someone to build a new release on an Erlang copy older than OTP-21 (which is no longer supported) which is unlikely.
This follows guidelines from
https://erlef.github.io/security-wg/secure_coding_and_deployment_hardening/ssl