Respect HEX_MIRROR environment variable #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mix and Hex don't use HEX_CDN for a long time. Mix can run Rebar3 to compile dependencies. To complete this Rebar3 may need to fetch plugins. It would be nice to specify Hex mirror for both Mix/Hex and Rebar3 using one variable.
dmitrivereshchagin
force-pushed
the
hex-mirror
branch
from
cf6dc7a to
8b85ab2
Compare
ferd
approved these changes
Oct 2, 2022
|
We're unlikely do deprecate the variable if it's just to rename it to something else that's fully equivalent. The current PR seems like a good fix for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mix and Hex don't use HEX_CDN for a long time. Mix can run Rebar3 to compile dependencies. To complete this Rebar3 may need to fetch plugins. It would be nice to specify Hex mirror for both Mix/Hex and Rebar3 using one variable.
Can we deprecate HEX_CDN in favor of HEX_MIRROR? If so, I can update PR.