Fix bad compiler path nesting #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annoying issue reported by users who had deeply nested source directories. The patches I've added to the compiler recently worked well up to 1-2 levels of nesting (which we tested for), but I messed up the merging of recursive path lists by doing them only at the top level. So when people had deeper-nested source structures, the paths were passed incorrectly and ignored some source files when resolving the DAG. Fix this so the path lists are merged at a level-order rather than only at the top, ensuring proper resolving.
tsloughter
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoying issue reported by users who had deeply nested source
directories. The patches I've added to the compiler recently worked well
up to 1-2 levels of nesting (which we tested for), but I messed up the
merging of recursive path lists by doing them only at the top level.
So when people had deeper-nested source structures, the paths were
passed incorrectly and ignored some source files when resolving the
DAG.
Fix this so the path lists are merged at a level-order rather than only
at the top, ensuring proper resolving.