Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dialyzer output file format configurable #2538

Merged
merged 4 commits into from
Apr 17, 2021
Merged

Make dialyzer output file format configurable #2538

merged 4 commits into from
Apr 17, 2021

Conversation

srijan
Copy link
Contributor

@srijan srijan commented Apr 17, 2021

Ref: #2524

ferd
ferd requested changes Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself seems good, but I've spotted some confusion about how arguments are being passed that likely needs clarification.

src/rebar_prv_dialyzer.erl Outdated Show resolved Hide resolved
src/rebar_prv_dialyzer.erl Outdated Show resolved Hide resolved
ferd
ferd reviewed Apr 17, 2021
View reviewed changes
src/rebar_prv_dialyzer.erl Outdated Show resolved Hide resolved
@ferd
Copy link
Collaborator

ferd commented Apr 17, 2021

Alright that's in a good state! Once CI passes I'll be merging this. Thanks for the contribution!

@ferd ferd merged commit 76085ae into erlang:master Apr 17, 2021
@srijan srijan deleted the dialyzer_fmt_options branch May 6, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srijan @ferd