fix injection of cth_readable to allow for hook configuration #2458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current behavior, rebar3 removes all cth_readable hooks from the config and adds the ones it wants. This however only works when using atoms only (which is normally used).
If we add a config to the hooks in the
rebar.confg
, the whole thing breaks:because
(Hooks -- AllReadableHooks)
assumes everything to be atoms. The type signature however is:(see https://erlang.org/doc/apps/common_test/ct_hooks_chapter.html)
This change is needed for ferd/cth_readable#34 to work correctly.