Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix injection of cth_readable to allow for hook configuration #2458

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

TheGeorge
Copy link

With the current behavior, rebar3 removes all cth_readable hooks from the config and adds the ones it wants. This however only works when using atoms only (which is normally used).

If we add a config to the hooks in the rebar.confg, the whole thing breaks:

{cth_hooks, [{cth_readable_failonly, []}]}

because (Hooks -- AllReadableHooks) assumes everything to be atoms. The type signature however is:

{ct_hooks,[my_cth_module]}
{ct_hooks,[{my_cth_module,[{debug,true}]}]}
{ct_hooks,[{my_cth_module,[{debug,true}],500}]}

(see https://erlang.org/doc/apps/common_test/ct_hooks_chapter.html)

This change is needed for ferd/cth_readable#34 to work correctly.

@ferd ferd merged commit 575890f into erlang:master Jan 6, 2021
@TheGeorge TheGeorge deleted the cth_readable_config branch January 6, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants